Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix trace-event-file-pattern description #22690

Closed
wants to merge 1 commit into from
Closed

src: fix trace-event-file-pattern description #22690

wants to merge 1 commit into from

Conversation

AndreasMadsen
Copy link
Member

Fix --trace-event-file-pattern description under node --help

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 4, 2018
@nodejs-github-bot
Copy link
Collaborator

@AndreasMadsen sadly an error occured when I tried to trigger a build :(

@richardlau

This comment has been minimized.

Sign in to view
@addaleax addaleax added duplicate Issues and PRs that are duplicates of other issues or PRs. and removed duplicate Issues and PRs that are duplicates of other issues or PRs. labels Sep 5, 2018
@addaleax
Copy link
Member

addaleax commented Sep 5, 2018

There’s a small difference – the “log-rotation id” bit. I guess removing that too makes sense, I just didn’t notice … so this just needs a rebase?

@AndreasMadsen AndreasMadsen force-pushed the fix-pattern-description branch from 77de51e to 6cfc492 Compare September 5, 2018 09:58
@BridgeAR
Copy link
Member

BridgeAR commented Sep 5, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/17031/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
@danbev
Copy link
Contributor

danbev commented Sep 7, 2018 •
edited
Loading

Rebuilding failing node-test-commit-freebsd

@danbev
Copy link
Contributor

danbev commented Sep 7, 2018

Landed in 1a57ad2.

@danbev danbev closed this Sep 7, 2018
danbev pushed a commit that referenced this pull request Sep 7, 2018
@AndreasMadsen @danbev
src: fix trace-event-file-pattern description
1a57ad2 
PR-URL: #22690
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 7, 2018
@AndreasMadsen @targos
src: fix trace-event-file-pattern description
44f1438 
PR-URL: #22690
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreasMadsen @nodejs-github-bot @richardlau @addaleax @BridgeAR @danbev