Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: generate debug symbols bundle on OS X #227

Closed
wants to merge 1 commit into from
Closed

src: generate debug symbols bundle on OS X #227

wants to merge 1 commit into from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 31, 2014

This will generate *.dSYM symbols on OS X, when we dispatch Node
binaries without debug symbols to users, it can be used to restore
meaningful stack trace from the crash report.

It doesn't affect generated binary.

@bnoordhuis
Copy link
Member

LGTM but out of curiosity, how big are the debug symbols? It would be somewhat unfortunate if the build starts writing gigabytes of mostly unused symbol data (think out of disk space errors.)

@zcbenz
src: generate debug symbols bundle on OS X
145e394 
This will generate *.dSYM symbols on OS X, when we dispatch Node
binaries without debug symbols to users, it can be used to restore
meaningful stack trace from the crash report.
@zcbenz
Copy link
Contributor Author

zcbenz commented Dec 31, 2014

I just updated the patch to only generate symbols for node target, so we won't waste time generating symbols for openssl-cli and others.

This patch now only generates a node.dSYM which is 187M in size, it also adds 10s building time on my machine.

@bnoordhuis
Copy link
Member

That's a little on the steep side IMO. When you say "can be used to restore meaningful stack trace from the crash report", who/what does that? The binary already has debug symbols.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 7, 2015

This is mostly used by developers building products based on io.js, who will distribute binaries that have no debug symbols, I have to admit it doesn't have much value to io.js itself. I'm OK to close this if you think it is not suitable to put it in upstream.

@bnoordhuis
Copy link
Member

@zcbenz Thanks for your reply, I'll go ahead and close this.

@bnoordhuis bnoordhuis closed this Jan 11, 2015
isaacs added a commit to npm/node that referenced this pull request Aug 6, 2019
@isaacs
deps: update npm to 6.10.3
8e7f26a 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [nodejs#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [nodejs#222](npm/cli#222)
  [nodejs#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [nodejs#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [nodejs#46](npm/hosted-git-info#46)
      [nodejs#43](npm/hosted-git-info#43)
      [nodejs#47](npm/hosted-git-info#47)
      [nodejs#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [nodejs#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))
Trott pushed a commit that referenced this pull request Aug 20, 2019
@isaacs @Trott
deps: update npm to 6.10.3
f769034 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: #29023
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@isaacs @BridgeAR
deps: update npm to 6.10.3
219c195 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: #29023
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 19, 2019
@isaacs @BethGriggs
deps: update npm to 6.10.3
55cd01c 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: #29023
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jul 28, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Feb 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Feb 2, 2024
Open
@akashmitra akashmitra mentioned this pull request Feb 2, 2024
Open
@kissofire kissofire mentioned this pull request Feb 2, 2024
Open
@luke7oaks luke7oaks mentioned this pull request Feb 2, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Feb 2, 2024
Open
@baby636 baby636 mentioned this pull request Feb 2, 2024
Open
@dannybrown13 dannybrown13 mentioned this pull request Feb 2, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Feb 2, 2024
Open
@Megoy-Tambayan Megoy-Tambayan mentioned this pull request Feb 2, 2024
Open
@baophucct baophucct mentioned this pull request Feb 2, 2024
Open
@jj-crypto jj-crypto mentioned this pull request Feb 2, 2024
Open
@MrBrain295 MrBrain295 mentioned this pull request Feb 2, 2024
Open
@xphillyx xphillyx mentioned this pull request Feb 2, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Feb 2, 2024
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Feb 2, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Feb 2, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 2, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Feb 2, 2024
Open
@sirinartk sirinartk mentioned this pull request Feb 2, 2024
Open
@137717unity 137717unity mentioned this pull request Feb 2, 2024
Open
@PinkDiamond1 PinkDiamond1 mentioned this pull request Feb 2, 2024
Open
@ambai ambai mentioned this pull request Feb 2, 2024
Open
@verdinjoshua1982 verdinjoshua1982 mentioned this pull request Feb 2, 2024
Open
@mrod0101 mrod0101 mentioned this pull request Feb 3, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Feb 3, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Feb 3, 2024
Open
@nickfnblum nickfnblum mentioned this pull request Feb 3, 2024
Open
@jhudaz jhudaz mentioned this pull request Feb 3, 2024
Open
@RickAllMighty8195 RickAllMighty8195 mentioned this pull request Feb 3, 2024
Open
@jen801 jen801 mentioned this pull request Feb 3, 2024
Open
@lasalasa lasalasa mentioned this pull request Feb 3, 2024
Open
@JoanKalanzi1 JoanKalanzi1 mentioned this pull request Feb 3, 2024
Open
@yotamselementor yotamselementor mentioned this pull request Feb 3, 2024
Open
@Fsub111 Fsub111 mentioned this pull request Feb 3, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Feb 3, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Feb 3, 2024
Open
@RoeeOren RoeeOren mentioned this pull request Feb 3, 2024
Open
@pratapadi pratapadi mentioned this pull request Feb 3, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Feb 3, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Feb 3, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 3, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @bnoordhuis