Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update eslint to v5.5.0 #22720

Closed
wants to merge 2 commits into from
Closed

tools: update eslint to v5.5.0 #22720

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Sep 6, 2018

Update eslint from 5.4.0 to 5.5.0. The changeset is mainly deletions due to updating a couple dependencies.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/809/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 6, 2018
trivikr
trivikr approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

jasnell
jasnell approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@silverwind
Copy link
Contributor

silverwind commented Sep 6, 2018 •
edited
Loading

Such a big diff again 😟. I wonder if we should attempt to bundle our dependencies like eslint to a single file using webpack, similar to how yarn does it for their releases. cc: @nodejs/linting

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 6, 2018

Since eslint is not platform specific it should not be required to run a full CI.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 6, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 6, 2018

Bundling would be a good way. If I remember correct @refack wanted to address this with rollup.

@Trott
Copy link
Member

Trott commented Sep 6, 2018

tools/node_modules/eslint/node_modules/esprima/ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

Other than that one thing, I get no diff when I update ESLint, so I'm 👍 on this, but please delete that one ChangeLog file.

@Trott
Copy link
Member

Trott commented Sep 6, 2018 •
edited
Loading

Such a big diff again 😟.

Yeah, that's why I decided not to open a PR when ESLint 5.5.0 came out. No new features that we're likely to use, and a big diff. (But that's not an objection from me! I'm OK with keeping it up to date just for the sake of having smaller diffs, even if some of them end up being disappointingly large anyway.)

@silverwind
Copy link
Contributor

ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

dnm only seems to search for Changelog, not ChangeLog, and its glob matching is performed case-sensitively. Suggesting to either change it to match insensitively or include ChangeLog.

@silverwind
Copy link
Contributor

@Trott inikulin/dmn#12

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 8, 2018

I just ran dmn@2 on this update and pushed the now deleted files in an extra commit.

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 9, 2018

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/845/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 11, 2018
@BridgeAR
tools: update eslint to v5.5.0
623dcb7 
PR-URL: nodejs#22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@BridgeAR
Copy link
Member Author

Landed in 623dcb7 🎉

@BridgeAR BridgeAR closed this Sep 11, 2018
targos pushed a commit that referenced this pull request Sep 11, 2018
@BridgeAR @targos
tools: update eslint to v5.5.0
62d7304 
PR-URL: #22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@targos targos mentioned this pull request Sep 18, 2018
Merged
@refack refack mentioned this pull request Apr 25, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @silverwind @Trott @jasnell @trivikr