Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove abort_on_uncaught_exception node.cc #22724

Closed
wants to merge 2 commits into from
Closed

src: remove abort_on_uncaught_exception node.cc #22724

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 6, 2018

This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove abort_on_uncaught_exception node.cc
b86579f 
This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.
@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/813/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 6, 2018
@danbev
Copy link
Contributor Author

danbev commented Sep 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17051/

addaleax
addaleax approved these changes Sep 6, 2018
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@danbev
Copy link
Contributor Author

danbev commented Sep 9, 2018

Landed in 6a9e776.

@danbev danbev closed this Sep 9, 2018
@danbev danbev deleted the remove-static-abort-on-uncaught branch September 9, 2018 11:45
danbev added a commit that referenced this pull request Sep 9, 2018
@danbev
src: remove abort_on_uncaught_exception node.cc
6a9e776 
This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

PR-URL: #22724
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 10, 2018
@danbev @targos
src: remove abort_on_uncaught_exception node.cc
c3c5141 
This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

PR-URL: #22724
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danbev @nodejs-github-bot @jasnell @addaleax