Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: move inspect in separate file #22845

Closed
wants to merge 2 commits into from
Closed

util: move inspect in separate file #22845

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

The inspect function became very big and it's better to handle this
in a separate file.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/882/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. util Issues and PRs related to the built-in util module. labels Sep 13, 2018
@addaleax
Copy link
Member

Two questions:

  • Any reason to not pick lib/internal/util/inspect.js?
  • We should probably backport this immediately after it lands – can you do that? :)

addaleax
addaleax approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see whether we might even be able to split this out into its own library eventually, that we could then vendor in.

@jdalton
Copy link
Member

jdalton commented Sep 13, 2018

Would love to see whether we might even be able to split this out into its own library eventually, that we could then vendor in.

😍 😻 😍 😻

@targos
Copy link
Member

targos commented Sep 14, 2018

We should probably backport this immediately after it lands – can you do that? :)

Yes, but please backport it with other pending changes to util.inspect

trivikr
trivikr approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev
Copy link
Contributor

danbev commented Sep 17, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17222/

@BridgeAR
Copy link
Member Author

@addaleax

Any reason to not pick lib/internal/util/inspect.js?

Not really. For me inspect should be a individual module instead of being part of util but I just missed the folder. I now moved it to lib/internal/util/inspect.js.

We should probably backport this immediately after it lands – can you do that? :)

Yes, definitely.

New CI after moving it again: https://ci.nodejs.org/job/node-test-pull-request/17227/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 18, 2018 •
edited
Loading

Rebuild arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/3593/
Rebuild other https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/961/
Rebuild failed part: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/994/

@joyeecheung joyeecheung mentioned this pull request Sep 18, 2018
Closed
@BridgeAR
util: move inspect in separate file
1e964d7 
The inspect function became very big and it's better to handle this
in a separate file.
@BridgeAR
Copy link
Member Author

Rebased due to conflicts.

CI https://ci.nodejs.org/job/node-test-pull-request/17324/

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 20, 2018 •
edited
Loading

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/17339/
CI https://ci.nodejs.org/job/node-test-pull-request/17341/ ✔️ (besides Windows)

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 21, 2018 •
edited
Loading

Rebuild Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20919/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 24, 2018
@BridgeAR
util: move inspect in separate file
c600a3c 
The inspect function became very big and it's better to handle this
in a separate file.

PR-URL: nodejs#22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in c600a3c

@BridgeAR BridgeAR closed this Sep 24, 2018
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2018
Closed
@targos
Copy link
Member

targos commented Sep 24, 2018

@BridgeAR please backport asap :)

@joyeecheung joyeecheung mentioned this pull request Sep 25, 2018
Closed
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 3, 2018
@BridgeAR
util: move inspect in separate file
a666cb7 
The inspect function became very big and it's better to handle this
in a separate file.

PR-URL: nodejs#22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 5, 2018
@BridgeAR @targos
util: move inspect in separate file
cbd851f 
The inspect function became very big and it's better to handle this
in a separate file.

Backport-PR-URL: #23226
PR-URL: #22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
@BridgeAR @targos
util: move inspect in separate file
77de1be 
The inspect function became very big and it's better to handle this
in a separate file.

Backport-PR-URL: #23226
PR-URL: #22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the move-inspect branch January 20, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@BridgeAR @nodejs-github-bot @addaleax @jdalton @targos @danbev @refack @jasnell @trivikr