Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove string literals for strictEquals/notStrictEquals #22891

Closed
wants to merge 2 commits into from
Closed

test: Remove string literals for strictEquals/notStrictEquals #22891

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2018

Ref: #22849.

In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

Ref: #22849.

In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2018
@danbev
Copy link
Contributor

danbev commented Sep 20, 2018

Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

test/parallel/test-async-wrap-trigger-id.js Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 22, 2018

@addaleax
Copy link
Member

Landed in ee31c28, thanks for the PR!

@addaleax addaleax closed this Sep 22, 2018
addaleax pushed a commit that referenced this pull request Sep 22, 2018
In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

Refs: #22849
PR-URL: #22891
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ghost ghost deleted the RemovingStringLiteralErrors branch September 23, 2018 00:48
@ghost
Copy link
Author

ghost commented Sep 23, 2018

Thanks all for you help!

targos pushed a commit that referenced this pull request Sep 23, 2018
In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

Refs: #22849
PR-URL: #22891
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants