Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix Array.prototype.forEach on v8 6.8 #22899

Closed
wants to merge 1 commit into from
Closed

deps: fix Array.prototype.forEach on v8 6.8 #22899

wants to merge 1 commit into from

Commits on Sep 22, 2018

  1. deps: fix Array.prototype.forEach on v8 6.8 

    This applies a variant of v8/v8@e1163c14f7e4fef2c549 to V8 6.8.

Original commit message:

    [Builtins] Array.prototype.forEach perf regression on dictionaries

    An unnecessary call to ToString() on the array index caused trips to
    the runtime. The fix also includes performance micro-benchmarks so
    we'll have a harder time regressing this case in future.

    TBR=tebbi@chromium.org

    Bug: v8:8112
    Change-Id: I781e8b1bbe2eb56db961cf33b0dca8523868b83d
    Reviewed-on: https://chromium-review.googlesource.com/1213207
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#55733}

Refs: v8/v8@e1163c1
Fixes: nodejs#22859
    @ripsawridge @addaleax
    ripsawridge authored and addaleax committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    1e8be82 View commit details
    Browse the repository at this point in the history