-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: specify fast-tracking #22929
doc: specify fast-tracking #22929
Conversation
+1 for the the simplicity, but I'd prefer to have the possibility to approve a PR without approving or rejecting the fast-tracking request without having to explicitely state this. I liked the convention to add a comment along the lines of "Please add 👍 here to approve fast-tracking" (I think @vsemozhetbyt introduced that?). |
I like the use of a comment with upvotes. What's wrong with it? |
If we give a LG to a PR, should we not also agree on fast-tracking or not? If someone disagrees, removing the label right away is best :) That way it's always clear what the intention is and it's more straight forward than having an extra comment that we have to upvote. |
@BridgeAR I don't think we should make that implication.
|
No strong preferences here, but a couple of quick thoughts:
|
97535c9
to
3bb07f9
Compare
I just reworded it to keep the comment type but to be specific about it. |
COLLABORATOR_GUIDE.md
Outdated
approve both the pull request and the fast-tracking request, and the necessary | ||
CI testing is done. | ||
`fast-track` and add a comment that collaborators may upvote. Please mention the | ||
collaborators that gave a approval before in that comment. If someone disagrees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a approval -> an approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please +1 if you agree with fast tracking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I don't think this PR should be fast tracked to allow other collaborators a chance to review (especially given that all collaborators were pinged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I agree with @richardlau, this shouldn't be fast-tracked.
Thanks :) I just added it because it already had a lot of LGs. I am somewhat puzzled why the linter failed. |
It's possible that the master branch has been force-pushed since this PR branched. Can you do a rebase and try again? @BridgeAR |
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion.
85251b1
to
c0c5247
Compare
COLLABORATOR_GUIDE.md
Outdated
CI testing is done. | ||
`fast-track` and add a comment that collaborators may upvote. Please mention the | ||
collaborators that gave an approval before in that comment. If someone disagrees | ||
with the fast-tracking request, please go ahead and remove the label and leave a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove go ahead and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit part two: probably remove please
in this sentence too. Just this?:
If someone disagrees with the fast-tracking request, remove the label and leave a comment...
Landed in 54af973. |
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: #22929 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: #22929 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Update: please check the commit message as description.
It is currently not clear if a PR approval also approves thefast-tracking request. This simplifies things by explicitly asking
the collaborators to remove the label if they disagree with it and
that any PR approval is also a fast-tracking approval from as soon
as the label is attached to the PR.
@nodejs/collaborators PTAL (sorry for pinging everyone but since this
is important for each one of us, it's important that everyone is on the same
page).
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes