[v10.x backport] inspector: workers debugging

.eslintrc.js

@@ -156,8 +156,13 @@ module.exports = {
     ],
     /* eslint-disable max-len */
     // If this list is modified, please copy the change to lib/.eslintrc.yaml
+    // and test/.eslintrc.yaml.
     'no-restricted-syntax': [
       'error',
+      {
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
+        message: 'Do not use a literal for the third argument of assert.deepStrictEqual()'
+      },
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
         message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'
@@ -166,6 +171,10 @@ module.exports = {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",
         message: 'assert.rejects() must be invoked with at least two arguments.',
       },
+      {
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='strictEqual'][arguments.2.type='Literal']",
+        message: 'Do not use a literal for the third argument of assert.strictEqual()'
+      },
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
         message: 'Use an object as second argument of assert.throws()',

.mailmap

@@ -131,6 +131,7 @@ Gabriel de Perthuis <g2p.code@gmail.com>
 Gareth Ellis <gareth.ellis@uk.ibm.com> <gareth@gsellis.com>
 Garwah Lam <garwahlam@gmail.com>
 Geoffrey Bugaisky <gbugaisk@gmail.com> gbugaisky <gbugaisk@gmail.com>
+Gerhard Stoebich <deb2001-github@yahoo.de>
 Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com>
 Gil Pedersen <git@gpost.dk> <github@gpost.dk>
 Graham Fairweather <xotic750@gmail.com> Xotic750 <xotic750@gmail>
@@ -204,6 +205,7 @@ Jérémy Lal <kapouer@melix.org> <holisme@gmail.com>
 Juan Sebastian Velez Posada <sebasvelez@gmail.com>
 Kai Sasaki Lewuathe <sasaki_kai@lewuathe.sakura.ne.jp>
 Karl Skomski <karl@skomski.com> <mail@skomski.com>
+Kat Marchán <kzm@zkat.tech> <kzm@sykosomatic.org>
 Kathy Truong <kathy.yvy.truong@gmail.com> k3kathy <kathy.yvy.truong@gmail.com>
 Kazuyuki Yamada <tasogare.pg@gmail.com>
 Keith M Wesolowski <wesolows@joyent.com> <wesolows@foobazco.org>
@@ -238,6 +240,7 @@ Matheus Marchini <mat@mmarchini.me> <matheus@sthima.com.br>
 Matheus Marchini <mat@mmarchini.me> <matheus@sthima.com>
 Matt Lang <matt@mediasuite.co.nz> matt-in-a-hat <matt@mediasuite.co.nz>
 Matt Reed <matthewreed26@gmail.com> matthewreed26 <matthewreed26@gmail.com>
+Matteo Collina <matteo.collina@gmail.com> <hello@matteocollina.com>
 Matthias Bastian <dev@matthias-bastian.de> piepmatz <piepmatz@users.noreply.github.com>
 Mathias Buus <mathiasbuus@gmail.com> <m@ge.tt>
 Mathias Pettersson <mape@mape.me>
@@ -364,6 +367,7 @@ Tadashi SAWADA <cesare@mayverse.jp>
 Takahiro ANDO <takahiro.ando@gmail.com>
 Tarun Batra <tarun.batra00@gmail.com> Tarun <tarun.batra00@gmail.com>
 Ted Young <ted@radicaldesigns.org>
+Teppei Sato <teppeis@gmail.com>
 Thomas Hunter II <me@thomashunter.name> <tom@intrinsic.com>
 Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>
 Thomas Reggi <thomas@reggi.com>
@@ -391,7 +395,8 @@ Vladimir de Turckheim <vlad2t@hotmail.com>
 vsemozhetbyt <vsemozhetbyt@gmail.com> Vse Mozhet Byt <vsemozhetbyt@gmail.com>
 Wang Xinyong <wang.xy.chn@gmail.com> <wangxy.chn@gmail.com>
 Weijia Wang <381152119@qq.com>
-Weijia Wang <381152119@qq.com> starkewang <starkewang@tencent.com>
+Weijia Wang <381152119@qq.com> <starkwang@126.com>
+Weijia Wang <381152119@qq.com> <starkewang@tencent.com>
 Wei-Wei Wu <wuxx1045@umn.edu>
 Willi Eggeling <email@wje-online.de>
 Will Hayslett <william.hayslettjr@gmail.com>

AUTHORS

@@ -650,7 +650,7 @@ Micleusanu Nicu <micnic90@gmail.com>
 Alejandro Oviedo Garcia <alejandro.oviedo.g@gmail.com>
 Ben Burns <benjamin.c.burns@gmail.com>
 Julian Duque <julianduquej@gmail.com>
-teppeis <teppeis@gmail.com>
+Teppei Sato <teppeis@gmail.com>
 Rudi Cilibrasi <cilibrar@morefuntechnologies.com>
 Tim Ruffles <oi@truffles.me.uk>
 CGavrila <cristi_gavrila1@yahoo.com>
@@ -754,14 +754,14 @@ Felipe Batista <fsbatista1@gmail.com>
 Rebecca Turner <me@re-becca.org>
 Tyler Anton <mtyleranton@gmail.com>
 João Reis <reis@janeasystems.com>
-Kat Marchán <kzm@sykosomatic.org>
+Kat Marchán <kzm@zkat.tech>
 Ryan Petschek <petschekr@gmail.com>
 Pierre Inglebert <pierre.inglebert@gmail.com>
 Ivan Yan <yan.2314@gmail.com>
 Sangmin Yoon <sangmin.yoon@croquis.com>
 Mark Plomer <mark.plomer@boerse-go.de>
 Phillip Johnsen <johphi@gmail.com>
-Matteo Collina <hello@matteocollina.com>
+Matteo Collina <matteo.collina@gmail.com>
 jomo <github@jomo.tv>
 Gireesh Punathil <gpunathi@in.ibm.com>
 Lucien Greathouse <me@lpghatguy.com>
@@ -1432,23 +1432,25 @@ Ahmad Nassri <ahmad@ahmadnassri.com>
 Tom Atkinson <atkinson.tommy@nhome.ba>
 Tobias Nießen <tniessen@tnie.de>
 Joseph Gentle <me@josephg.com>
+Arunesh Chandra <arunesh.chandra@microsoft.com>
+Gabriel Schulhof <gabriel.schulhof@intel.com>
+Ian Halliday <ianhall@microsoft.com>
+Sampson Gao <sampsong@ca.ibm.com>
+Taylor Woll <taylor.woll@microsoft.com>
 Zero King <l2dy@icloud.com>
 Raphael Okon <raphael@okon.io>
 JR McEntee <jrmce12@gmail.com>
 Lovell Fuller <github@lovell.info>
 Jason Marsh <regularly.jason@gmail.com>
 Vinay Hiremath <vhiremath4@gmail.com>
-Gabriel Schulhof <gabriel.schulhof@intel.com>
 alejandro <alemures@hotmail.com>
 dave-k <davek1802@gmail.com>
 Steven <steven@ceriously.com>
 Uppinder Chugh <uppinderchugh@gmail.com>
 Karl Cheng <qantas94heavy@gmail.com>
-Taylor Woll <taylor.woll@microsoft.com>
 Tarun Batra <tarun.batra00@gmail.com>
 Nao YONASHIRO <owan.orisano@gmail.com>
 Christopher Luke <zaide@zaidesthings.com>
-Sampson Gao <sampsong@ca.ibm.com>
 John Paul Bamberg <jpbamberg1993@gmail.com>
 Cody Deckard <cjdeckard@gmail.com>
 Fabio Campinho <fcampinho@gmail.com>
@@ -1488,7 +1490,7 @@ Madara Uchiha <me@madara.ninja>
 Gil Tayar <gil@tayar.org>
 Glenn Schlereth <Glenn.Schlereth@gmail.com>
 Artur G Vieira <vieira.artur.g@gmail.com>
-Flarna <deb2001-github@yahoo.de>
+Gerhard Stoebich <deb2001-github@yahoo.de>
 Sreepurna Jasti <sreepurna.jasti@gmail.com>
 Rafael Fragoso <rafaelfragosom@gmail.com>
 Andrei Cioromila <andrei.cioromila@gmail.com>
@@ -1658,6 +1660,8 @@ Piotr Mionskowski <piotr.mionskowski@gmail.com>
 Cyril Lakech <cyril.lakech@axa.fr>
 Eduard Bondarenko <eduardbcom@gmail.com>
 Adina Shanholtz <ashanhol@gmail.com>
+Guy Bedford <guybedford@gmail.com>
+Jan Krems <jan.krems@groupon.com>
 Miguel Martins <mmartins@uphold.com>
 Yury Popov <github@phoenix.dj>
 George Bezerra <georgelione@gmail.com>
@@ -1670,7 +1674,6 @@ Alex Gresnel <31708810+agresnel@users.noreply.github.com>
 Will Young <lost.networking@gmail.com>
 Martijn Schrage <martijn@oblomov.com>
 Halil İbrahim Şener <hisener@yahoo.com>
-Guy Bedford <guybedford@gmail.com>
 Antoine Amara <amara.antoine@gmail.com>
 Mani Maghsoudlou <manidlou@gmail.com>
 Bartek Szczepański <hello@barnski.pl>
@@ -1884,7 +1887,6 @@ Ashish Kaila <ashishkaila@hotmail.com>
 c0b <14798161+c0b@users.noreply.github.com>
 Damian <damianczapiewski@gmail.com>
 Alec Perkins <alecperkins@gmail.com>
-Teppei Sato <teppeis@gmail.com>
 Jinwoo Lee <jinwoo68@gmail.com>
 Peter Marton <email@martonpeter.com>
 Erwin W. Ramadhan <erwinwahyuramadhan@gmail.com>
@@ -2154,9 +2156,7 @@ Nick Filatov <keddofilatov@gmail.com>
 Jesse Gorzinski <jgorzinski@gmail.com>
 Pieter Mees <pieter.mees@zentrick.com>
 Malcolm White <malcolmwhite@google.com>
-Gerhard Stoebich <deb2001-github@yahoo.de>
 Matei Copot <matei@copot.eu>
-ikasumiwt <wtsnyk13@gmail.com>
 Gurin, Sebastian <sgurin@netsuite.com>
 Indranil Dasgupta <indranild@gmail.com>
 Harry Sarson <harry.sarson@hotmail.co.uk>
@@ -2187,7 +2187,6 @@ Kyle Martin <kyle.martin@hotmail.co.nz>
 Denis Fäcke <serayaeryn@gmail.com>
 Daylor Yanes <daylor.yanes@gmail.com>
 Carrie Coxwell <carrie.coxwell@gmail.com>
-BeniCheni <benjaminlchen@gmail.com>
 Masashi Hirano <cherrydog07@gmail.com>
 Brandon Ruggles <brandonrninefive@gmail.com>
 Allen Yonghuang Wang <helloshuangzi@gmail.com>
@@ -2218,6 +2217,7 @@ Abhimanyu Vashisht <abhimanyuvashisht.av@gmail.com>
 Sagir Khan <sagir.khan@gmail.com>
 Kael Zhang <i+github@kael.me>
 Unknown <bdistin@gmail.com>
+Krzysztof Taborski <taborskikrzysztof@gmail.com>
 Blaine Bublitz <blaine.bublitz@gmail.com>
 Shailesh Shekhawat <sshekhawat356@gmail.com>
 Davis Okoth <davisokoth@gmail.com>
@@ -2236,5 +2236,86 @@ Shelley Vohr <shelley.vohr@gmail.com>
 Deepjyoti Mondal <djmdeveloper060796@gmail.com>
 Brett Kiefer <brett@trello.com>
 Kevin Thomas <kevintab95@gmail.com>
+ZaneHannanAU <ZaneHannanAU@users.noreply.github.com>
+Fernando Doglio <deleteman@gmail.com>
+Renée Kooi <renee@kooi.me>
+Jo Colina <jo@bottomatik.com>
+itaysabato <itaysabato@gmail.com>
+Victor Belozyorov <hi@vbelozyorov.com>
+Joonas Rouhiainen <joonas.rouhiainen@reaktor.com>
+GauthamBanasandra <gautham.bangalore@gmail.com>
+Hugo Josefson <hugo@josefson.org>
+Sam Ruby <rubys@intertwingly.net>
+Haroon Khan <aitchkhan@gmail.com>
+Developer Davo <DeveloperDavo@users.noreply.github.com>
+Jacek Pospychała <jacek.pospychala@currency-one.com>
+MaleDong <maledong_private@qq.com>
+iwko <iwoczerniawski@gmail.com>
+Sohail Rajdev <sohailrajdev97@gmail.com>
+Niicck <niicck@users.noreply.github.com>
+Denys Otrishko <shishugi@gmail.com>
+Sergey Zelenov <mail@zelenov.su>
+Travis Fischer <fisch0920@gmail.com>
+Dominic Farolino <domfarolino@gmail.com>
+Octavian Soldea <octavian.soldea@intel.com>
+XhmikosR <xhmikosr@gmail.com>
+AdityaSrivast <yashsri421@gmail.com>
+Javier Gonzalez <xaviergonz@gmail.com>
+RidgeA <antongriadchenko@gmail.com>
+Ryuichi Sakagami <shagamiiiii@gmail.com>
+hectorcoronado <hectorcoronado.developer@gmail.com>
+Petras <15868923+kimberlake@users.noreply.github.com>
+Kevin Lacabane <5239883+klacabane@users.noreply.github.com>
+Simionescu, Radu <radsimu@gmail.com>
+mariotsi <simone@mariotti.me>
+prayag21 <10997858+prayag21@users.noreply.github.com>
+Bruno Pinho <bpinhosilva@gmail.com>
+Anto Aravinth <anto.aravinth.cse@gmail.com>
+Helio Frota <00hf11@gmail.com>
+Tim Ruffles <timruffles@googlemail.com>
+Jacob Page <jpage@godaddy.com>
+sagulati <sagulati@adobe.com>
+conectado <gabrielalejandro7@gmail.com>
+Vitor Bruno de Oliveira Barth <vbob@vbob.com.br>
+cclauss <cclauss@bluewin.ch>
+James Ide <ide@expo.io>
+MaleDong <maledong_github@outlook.com>
+bhavayAnand9 <bhavayanandcse@gmail.com>
+Brandon Lee <40652534+brandonlwt@users.noreply.github.com>
+Oryan Moshe <iamoryanmoshe@gmail.com>
+Michael Sommer <sommerdrummer@gmail.com>
+Eugene Y. Q. Shen <eugene@eyqs.ca>
+Rishabh Singh <rishabhptr@gmail.com>
+Marco Levrero <marco.levrero@gmail.com>
+Ouyang Yadong <oyydoibh@gmail.com>
+yahavfuchs <yahavf6@gmail.com>
+Thomas Leah <thomas@leahfamily.plus.com>
+Musa Hamwala <musahamwala@icloud.com>
+James Bromwell <james.bromwell@gdit.com>
+Jeremy Apthorp <nornagon@nornagon.net>
+Eugen Cazacu <32613393+oygen87@users.noreply.github.com>
+James Bromwell <943160+thw0rted@users.noreply.github.com>
+Csaba Palfi <csaba@palfi.me>
+Ryan Petrich <rpetrich@gmail.com>
+Andreas Girgensohn <andreasg@fxpal.com>
+Caleb Sander <caleb.sander@gmail.com>
+Dzmitry_Prudnikau <dzmitriyprudnikov@gmail.com>
+Ian McKellar <ianloic@google.com>
+Jennifer Bland <jennifer.bland@sbdinc.com>
+Kyle Fuller <kyle@fuller.li>
+ZYSzys <zyszys98@gmail.com>
+Neeraj Laad <neeraj.laad@uk.ibm.com>
+Scott Van Gilder <svangilder@gmail.com>
+Yaniv Friedensohn <yaniv.friedensohn@gmail.com>
+Lars-Magnus Skog <ralphtheninja@riseup.net>
+Lucas Woo <legendecas@gmail.com>
+Troels Liebe Bentsen <troels@connectedcars.dk>
+pranshuchittora <pranshuchittora17@gmail.com>
+lakamsani <lakamsani@gmail.com>
+Chris White <cxwembedded@gmail.com>
+Ben Newman <ben@meteor.com>
+Szymon Marczak <sz.marczak@gmail.com>
+Tessei Kameyama <kamenoko315@ruri.waseda.jp>
+Chakravarthy S M <chakra.mithun@gmail.com>
 
-# Generated by tools/update-authors.sh
+# Generated by tools/update-authors.js

COLLABORATOR_GUIDE.md

@@ -21,6 +21,7 @@
     - [When Breaking Changes Actually Break Things](#when-breaking-changes-actually-break-things)
       - [Reverting commits](#reverting-commits)
   - [Introducing New Modules](#introducing-new-modules)
+  - [Additions to N-API](#additions-to-n-api)
   - [Deprecations](#deprecations)
   - [Involving the TSC](#involving-the-tsc)
 * [Landing Pull Requests](#landing-pull-requests)
@@ -411,6 +412,18 @@ For new modules that involve significant effort, non-trivial additions to
 Node.js or significant new capabilities, an [Enhancement Proposal][] is
 recommended but not required.
 
+### Additions to N-API
+
+N-API provides an ABI stable API that we will have to support in future
+versions without the usual option to modify or remove existing APIs on
+SemVer boundaries. Therefore, additions need to be managed carefully.
+
+This
+[guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md)
+outlines the requirements and principles that we should follow when
+approving and landing new N-API APIs (any additions to `node_api.h` and
+`node_api_types.h`).
+
 ### Deprecations
 
 [_Deprecation_][] is "the discouragement of use of some … feature … or practice,

Makefile

@@ -1087,7 +1087,8 @@ tools/.docmdlintstamp: $(LINT_MD_DOC_FILES)
 LINT_MD_TARGETS = src lib benchmark test tools/doc tools/icu
 LINT_MD_ROOT_DOCS := $(wildcard *.md)
 LINT_MD_MISC_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
-  -not -path '*node_modules*' -name '*.md') $(LINT_MD_ROOT_DOCS)
+  -not -path '*node_modules*' -not -path 'test/fixtures/*' -name '*.md') \
+  $(LINT_MD_ROOT_DOCS)
 run-lint-misc-md = tools/lint-md.js -q -f $(LINT_MD_MISC_FILES)
 # Lint other changed markdown files maintained by us
 tools/.miscmdlintstamp: $(LINT_MD_MISC_FILES)

README.md

@@ -249,6 +249,8 @@ For more information about the governance of the Node.js project, see
 **Franziska Hinkelmann** <franziska.hinkelmann@gmail.com> (she/her)
 * [Fishrock123](https://github.com/Fishrock123) -
 **Jeremiah Senkpiel** <fishrock123@rocketmail.com>
+* [gabrielschulhof](https://github.com/gabrielschulhof) -
+**Gabriel Schulhof** <gabriel.schulhof@intel.com>
 * [gibfahn](https://github.com/gibfahn) -
 **Gibson Fahnestock** <gibfahn@gmail.com> (he/him)
 * [jasnell](https://github.com/jasnell) -
@@ -331,6 +333,8 @@ For more information about the governance of the Node.js project, see
 **Benedikt Meurer** <benedikt.meurer@gmail.com>
 * [bnoordhuis](https://github.com/bnoordhuis) -
 **Ben Noordhuis** <info@bnoordhuis.nl>
+* [boneskull](https://github.com/boneskull) -
+**Christopher Hiller** <boneskull@boneskull.com> (he/him)
 * [brendanashworth](https://github.com/brendanashworth) -
 **Brendan Ashworth** <brendan.ashworth@me.com>
 * [BridgeAR](https://github.com/BridgeAR) -

benchmark/fs/bench-mkdirp.js

@@ -0,0 +1,23 @@
+'use strict';
+
+const common = require('../common');
+const fs = require('fs');
+const tmpdir = require('../../test/common/tmpdir');
+tmpdir.refresh();
+let dirc = 0;
+
+const bench = common.createBenchmark(main, {
+  n: [1e4],
+});
+
+function main({ n }) {
+  bench.start();
+  (function r(cntr) {
+    if (cntr-- <= 0)
+      return bench.end(n);
+    const pathname = `${tmpdir.path}/${++dirc}/${++dirc}/${++dirc}/${++dirc}`;
+    fs.mkdir(pathname, { createParents: true }, (err) => {
+      r(cntr);
+    });
+  }(n));
+}

common.gypi

@@ -29,7 +29,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.25',
+    'v8_embedder_string': '-node.29',
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,

deps/v8/include/v8-inspector.h

@@ -214,6 +214,11 @@ class V8_EXPORT V8InspectorClient {
   virtual bool canExecuteScripts(int contextGroupId) { return true; }
 
   virtual void maxAsyncCallStackDepthChanged(int depth) {}
+
+  virtual std::unique_ptr<StringBuffer> resourceNameToUrl(
+      const StringView& resourceName) {
+    return nullptr;
+  }
 };
 
 // These stack trace ids are intended to be passed between debuggers and be

deps/v8/src/field-type.cc

@@ -78,6 +78,7 @@ void FieldType::PrintTo(std::ostream& os) {
     os << "None";
   } else {
     DCHECK(IsClass());
+    HandleScope scope(Map::cast(this)->GetIsolate());
     os << "Class(" << static_cast<void*>(*AsClass()) << ")";
   }
 }

deps/v8/src/inspector/v8-debugger-agent-impl.cc

@@ -1444,7 +1444,7 @@ void V8DebuggerAgentImpl::didParseSource(
         protocol::StringUtil::parseJSON(inspected->auxData()));
   }
   bool isLiveEdit = script->isLiveEdit();
-  bool hasSourceURL = script->hasSourceURL();
+  bool hasSourceURLComment = script->hasSourceURLComment();
   bool isModule = script->isModule();
   String16 scriptId = script->scriptId();
   String16 scriptURL = script->sourceURL();
@@ -1464,7 +1464,8 @@ void V8DebuggerAgentImpl::didParseSource(
   Maybe<protocol::DictionaryValue> executionContextAuxDataParam(
       std::move(executionContextAuxData));
   const bool* isLiveEditParam = isLiveEdit ? &isLiveEdit : nullptr;
-  const bool* hasSourceURLParam = hasSourceURL ? &hasSourceURL : nullptr;
+  const bool* hasSourceURLParam =
+      hasSourceURLComment ? &hasSourceURLComment : nullptr;
   const bool* isModuleParam = isModule ? &isModule : nullptr;
   std::unique_ptr<V8StackTraceImpl> stack =
       V8StackTraceImpl::capture(m_inspector->debugger(), contextGroupId, 1);