errors: use ERR_OUT_OF_RANGE for index errors #22969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is capable of providing more detail. (In one instance, use ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.)
Trott
added
semver-major
nodejs-github-bot
added
c++
BridgeAR
reviewed
Sep 20, 2018
| triggerAsyncId1, | ||
| 'Async resources having different causal ancestry ' + | ||
| 'should have different triggerAsyncIds'); | ||
| triggerAsyncId1); |
There was a problem hiding this comment.
Nit: this should now fit on a single line.
richardlau
reviewed
Sep 20, 2018
richardlau
previously requested changes
Sep 20, 2018
jasnell
approved these changes
Sep 20, 2018
joyeecheung
approved these changes
Sep 20, 2018
|
Removed one of the three error message checks. It's for a message that originates in C++ and appears to vary based on OS. The error code and type are still checked. And there are still two other message checks. |
lpinca
approved these changes
Sep 20, 2018
|
A few test-crypto-keygen failures. Known flaky with a fix being fast-tracked right now. Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17347/ |
|
Windows fanned Resume Build: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20904/ |
starkwang
approved these changes
Sep 21, 2018
|
Windows Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20909/ ✔️ |
|
Landed in f8d6991 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 27, 2018
Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is capable of providing more detail. (In one instance, use ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.) PR-URL: nodejs#22969 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is
capable of providing more detail. (In one instance, use
ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.)
Updated variable names to match documentation and error messages.
Updated some test cases to only check the error code and type and not the error message which should be subject to change.
h/t @apapirovski for help with troubleshooting C++ compilation errors because...yeah, that's not my strong suit
Labeling
semver-majorbecause error code changes are breaking changes. @nodejs/tscChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes