doc,test: fix inspect's sorted compare function #22992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly.
targos
added
util
|
👍 to fast-track and unblock #22754 |
BridgeAR
approved these changes
Sep 21, 2018
cjihrig
approved these changes
Sep 21, 2018
|
How does this compare to #23000 which is modifying the same bit of code in the test? |
4 tasks
richardlau
removed
the
fast-track
|
Does localeCompare require Intl support? Given that I don't see any other usages of localeCompare in the test directory, maybe my fix is preferrable? |
jasnell
approved these changes
Sep 21, 2018
kfarnung
approved these changes
Sep 21, 2018
|
I added |
addaleax
added
the
author ready
|
@kfarnung Thank you. |
|
Landed in e758d4a |
targos
added a commit
that referenced
this pull request
Sep 22, 2018
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly. PR-URL: #22992 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
targos
added a commit
to targos/node
that referenced
this pull request
Sep 23, 2018
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly. PR-URL: nodejs#22992 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
targos
added a commit
that referenced
this pull request
Sep 24, 2018
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly. Backport-PR-URL: #23039 PR-URL: #22992 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
targos
added
backported-to-v10.x
and removed
author ready
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In V8 7.0, the array sorting algorithm was changed to Timsort, which
is stable. A compare function returning only
trueorfalse(converted to 0 and 1) cannot work properly.