Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: synopsis-docs match Hello, World! example in console output. #23006

Closed
wants to merge 1 commit into from
Closed

doc: synopsis-docs match Hello, World! example in console output. #23006

wants to merge 1 commit into from

Conversation

MohammedEssehemy
Copy link
Contributor

fix typo in console output for Hello, World! example in synopsis docs.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 21, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/963/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2018
@vsemozhetbyt
Copy link
Contributor

Line 13 seems also a bit off)

@MohammedEssehemy
Copy link
Contributor Author

@vsemozhetbyt which line do you mean? the only changed lines are 74 and 97.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 21, 2018 •
edited
Loading

I mean that the unchanged line 13 can also be fixed if you want)

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 21, 2018
@MohammedEssehemy
Copy link
Contributor Author

@vsemozhetbyt Aha got it, I've changed it now.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 21, 2018 •
edited
Loading

CI-lite 2: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/967/

@vsemozhetbyt
Copy link
Contributor

Landed in 5942a34
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Sep 21, 2018
@MohammedEssehemy @vsemozhetbyt
doc: match program and console output in synopsis.md
5942a34 
PR-URL: #23006
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 23, 2018
@MohammedEssehemy @targos
doc: match program and console output in synopsis.md
d3bc862 
PR-URL: #23006
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MohammedEssehemy @vsemozhetbyt @lpinca @nodejs-github-bot