process,tty: allow reading/writing from duplex sockets #23053

addaleax · 2018-09-24T10:23:02Z

As of libuv 1.23.1, the direction of OS-level streams is automatically detected, meaning that reading from stdout/stderr and writing to process.stdin are working again. Making this work completely (i.e. no error when the stream ends) requires some additional fixups to our stdio code.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This reverts commit 91eec00. Refs: nodejs#21654 Refs: nodejs#21203

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it.

Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: nodejs#21203

Make sure that `process.stdin.write()`, and in particular ending the stream, works.

nodejs-github-bot · 2018-09-24T10:23:03Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/993/pipeline

vsemozhetbyt · 2018-09-24T16:56:51Z

Is it worth to move the obsolete errors to the Legacy Node.js Error Codes section?

Refs: #22100

doc/api/errors.md

vsemozhetbyt · 2018-09-24T17:43:32Z

doc/api/errors.md

@@ -2065,6 +2078,13 @@ instance.setEncoding('utf8');
 An attempt has been made to create a string larger than the maximum allowed
 size.

+<a id="ERR_TTY_WRITABLE_NOT_READABLE"></a>
+### ERR_TTY_WRITABLE_NOT_READABLE


Nit: ### -> #### for level consistency)

Done … this seems like something that our linter could maybe catch as well?

It seems, in this case, it will not be clear for a linter if this is a new level or just a typo.

…ABLE"

addaleax · 2018-09-30T15:26:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17519/

addaleax · 2018-10-03T20:50:10Z

Windows re-build: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21239/ ✔️

addaleax · 2018-10-04T16:25:12Z

Landed in 17a0cd2...8bf48bf

I’ve added this to the 11.0.0 milestone because it reverts a semver-major change that would otherwise be released in that version.

This reverts commit 91eec00. Refs: #21654 Refs: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

This reverts commit 91eec00. Refs: #21654 Refs: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

This has been unused since cbc3ef6. Refs: nodejs#23053

This has been unused since cbc3ef6. Refs: #23053 PR-URL: #25641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: #21203 Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Make sure that `process.stdin.write()`, and in particular ending the stream, works. Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

This has been unused since cbc3ef6. Refs: #23053 PR-URL: #25641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: nodejs/node#23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: nodejs/node#21203 PR-URL: nodejs/node#23053 Reviewed-By: James M Snell <jasnell@gmail.com>

Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: nodejs/node#23053 Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added 4 commits September 24, 2018 11:15

Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

a4e4e48

This reverts commit 91eec00. Refs: nodejs#21654 Refs: nodejs#21203

tools: allow input for TTY tests

4467b66

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it.

test: add stdin writable regression test

c39c8ac

Make sure that `process.stdin.write()`, and in particular ending the stream, works.

addaleax requested a review from mcollina September 24, 2018 10:23

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 24, 2018

addaleax added process Issues and PRs related to the process subsystem. tty Issues and PRs related to the tty subsystem. labels Sep 24, 2018

vsemozhetbyt reviewed Sep 24, 2018

View reviewed changes

doc/api/errors.md Show resolved Hide resolved

addaleax added 2 commits September 24, 2018 19:02

fixup! process: allow reading from stdout/stderr sockets

5266788

fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

2fb5f00

vsemozhetbyt reviewed Sep 24, 2018

View reviewed changes

fixup! fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READ…

df004fb

…ABLE"

jasnell approved these changes Oct 1, 2018

View reviewed changes

joyeecheung mentioned this pull request Oct 2, 2018

CI failures: 20180927-20181002 nodejs/reliability#18

Closed

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2018

addaleax added this to the 11.0.0 milestone Oct 4, 2018

addaleax closed this Oct 4, 2018

addaleax deleted the tty-allow-read branch October 4, 2018 16:25

addaleax added a commit that referenced this pull request Oct 4, 2018

Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

c7405fe

This reverts commit 91eec00. Refs: #21654 Refs: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Oct 4, 2018

tools: allow input for TTY tests

d0fc382

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Oct 4, 2018

test: add stdin writable regression test

8bf48bf

Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

refack added test Issues and PRs related to the tests. python PRs and issues that require attention from people who are familiar with Python. labels Oct 4, 2018

jasnell pushed a commit that referenced this pull request Oct 17, 2018

Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

c834be0

This reverts commit 91eec00. Refs: #21654 Refs: #21203 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request Oct 17, 2018

tools: allow input for TTY tests

90ffcd5

Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request Oct 17, 2018

test: add stdin writable regression test

987bfcf

Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced Oct 23, 2018

“Unknown system error -75” nodejs fs.stat large files #19455

Closed

Updating libuv on 8.x and 10.x #23833

Closed

mcollina mentioned this pull request Dec 24, 2018

tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE #21654

Closed

3 tasks

shrikrishnaholla mentioned this pull request Dec 24, 2018

process,tty: allow reading/writing from duplex sockets : backport to node-8 #25204

Closed

addaleax added a commit to addaleax/node that referenced this pull request Jan 22, 2019

test: remove unused uncaughtException handler

d8d2d23

This has been unused since cbc3ef6. Refs: nodejs#23053

addaleax mentioned this pull request Jan 22, 2019

test: remove unused uncaughtException handler #25641

Closed

3 tasks

BethGriggs pushed a commit that referenced this pull request Mar 19, 2019

test: add stdin writable regression test

c56f3ed

Make sure that `process.stdin.write()`, and in particular ending the stream, works. Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Mar 26, 2019

v8.16.0 proposal #26933

Merged

vweevers mentioned this pull request Mar 20, 2020

Different behavior between transform function and async generator using pipelines #32363

Closed

ronag mentioned this pull request Mar 20, 2020

stream: complete pipeline with stdio #32373

Closed

4 tasks

ronag mentioned this pull request May 4, 2020

stdout not usable after pipeline? #33237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process,tty: allow reading/writing from duplex sockets #23053

process,tty: allow reading/writing from duplex sockets #23053

addaleax commented Sep 24, 2018

nodejs-github-bot commented Sep 24, 2018

vsemozhetbyt commented Sep 24, 2018 •

edited

Loading

vsemozhetbyt Sep 24, 2018

addaleax Sep 24, 2018

vsemozhetbyt Sep 24, 2018

addaleax commented Sep 30, 2018

addaleax commented Oct 3, 2018 •

edited by danbev

Loading

addaleax commented Oct 4, 2018

process,tty: allow reading/writing from duplex sockets #23053

process,tty: allow reading/writing from duplex sockets #23053

Conversation

addaleax commented Sep 24, 2018

Checklist

nodejs-github-bot commented Sep 24, 2018

vsemozhetbyt commented Sep 24, 2018 • edited Loading

vsemozhetbyt Sep 24, 2018

Choose a reason for hiding this comment

addaleax Sep 24, 2018

Choose a reason for hiding this comment

vsemozhetbyt Sep 24, 2018

Choose a reason for hiding this comment

addaleax commented Sep 30, 2018

addaleax commented Oct 3, 2018 • edited by danbev Loading

addaleax commented Oct 4, 2018

vsemozhetbyt commented Sep 24, 2018 •

edited

Loading

addaleax commented Oct 3, 2018 •

edited by danbev

Loading