Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve reliability of test-gc-http-client #23087

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 25, 2018

test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.

Fixes: #22336

Labeling fast-track to fix flaky CI and because this is awfully easy to undo if someone comes up with a better solution. Please 👍 to approve fast-tracking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.

Fixes: nodejs#22336
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 25, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 25, 2018
@Trott
Copy link
Member Author

Trott commented Sep 25, 2018

@addaleax
Copy link
Member

For both this and #23086, can you remove the Fixes:? Even if it makes the test pass, we still have a bug in the test or Node.js (and a slower test suite).

@addaleax addaleax added the http Issues or PRs related to the http subsystem. label Sep 25, 2018
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @addaleax , this should likely to help making the test break less often but does not really fix it AFAICT

@danbev
Copy link
Contributor

danbev commented Sep 26, 2018

Landed in 7d03ff1.

@danbev danbev closed this Sep 26, 2018
danbev pushed a commit that referenced this pull request Sep 26, 2018
test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.

Approved for fast-tracking by:
Anna Henningsen <anna@addaleax.net>
Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: #23087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 27, 2018
test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.

Approved for fast-tracking by:
Anna Henningsen <anna@addaleax.net>
Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: #23087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott deleted the test-gc-http-client branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky parallel/test-gc-http-client
6 participants