Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused locale.h #23120

Closed
wants to merge 2 commits into from
Closed

src: remove unused locale.h #23120

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 27, 2018

This commit removes the locale.h header as it does not look like it is
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1039/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 27, 2018
mhdawson
mhdawson approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thefourtheye
thefourtheye approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy.

@danbev
src: remove unused locale.h
233cfa3 
This commit removes the locale.h header as it does not look like it is
used.
@danbev
src: remove unused using declarations
399576b
@danbev danbev force-pushed the node_remove_locale_header branch from ee37883 to 399576b Compare September 28, 2018 03:22
@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/17484/

@addaleax
Copy link
Member

Can’t do ARM-only rebuilds atm, so here’s a complete rebuild: https://ci.nodejs.org/job/node-test-pull-request/17530/

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Another CI: https://ci.nodejs.org/job/node-test-pull-request/17551/

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Landed in 0de2caf, and e7b6589.

@danbev danbev closed this Oct 1, 2018
@danbev danbev deleted the node_remove_locale_header branch October 1, 2018 11:00
danbev added a commit that referenced this pull request Oct 1, 2018
@danbev
src: remove unused locale.h
0de2caf 
This commit removes the locale.h header as it does not look like it is
used.

PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request Oct 1, 2018
@danbev
src: remove unused using declarations
e7b6589 
PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
@danbev @targos
src: remove unused locale.h
babf9be 
This commit removes the locale.h header as it does not look like it is
used.

PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
@danbev @targos
src: remove unused using declarations
5c97ee0 
PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@danbev @targos
src: remove unused locale.h
0202c6c 
This commit removes the locale.h header as it does not look like it is
used.

PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
@danbev @targos
src: remove unused using declarations
64689ed 
PR-URL: #23120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @nodejs-github-bot @addaleax @jasnell @thefourtheye @mhdawson