Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-gc-http-client-connaborted #23193

Closed
wants to merge 1 commit into from
Closed

test: improve test-gc-http-client-connaborted #23193

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

@lundibundi lundibundi commented Oct 1, 2018 •
edited
Loading

  • refactor out usage of 'function' for scoping
  • wait till server is up to start firing requests
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This has been failing a lot recently so tried to make this less intensive, refactor a bit. With this, I was able to run this with '-j 32 --repeat 1920' in 'test/parallel' on 4 core (8 thread) i7.

@lundibundi lundibundi self-assigned this Oct 1, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2018 •
edited by lundibundi
Loading

@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1083/pipeline

CI: https://ci.nodejs.org/job/node-test-pull-request/17553/

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 1, 2018
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2018
@lundibundi
Copy link
Member Author

Ok, this test as failed on windows on CI. Even though this (IMO) is an improvement it's still not enough. I think we can land this anyway as it should at least decrease the rate at which we are getting failures.

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2018
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

decrease amount of requests 500 -> 300

I think that might help with masking a real problem, see nodejs/reliability#18 (comment).

@lundibundi
test: improve test-gc-http-client-connaborted
67771e9 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests
@lundibundi lundibundi force-pushed the improve-gc-http-connaborted branch from 2ea292f to 67771e9 Compare October 8, 2018 22:51
@lundibundi
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17690/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2018
@addaleax
Copy link
Member

Landed in 63a6352

@addaleax addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
@lundibundi @addaleax
test: improve test-gc-http-client-connaborted
63a6352 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Trott pushed a commit that referenced this pull request Oct 13, 2018
@lundibundi @Trott
test: improve test-gc-http-client-connaborted
584470c 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2018
@lundibundi @targos
test: improve test-gc-http-client-connaborted
9197a72 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@lundibundi @jasnell
test: improve test-gc-http-client-connaborted
91bad82 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@lundibundi @MylesBorins
test: improve test-gc-http-client-connaborted
693a50e 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@lundibundi @rvagg
test: improve test-gc-http-client-connaborted
c40bf97 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@lundibundi @MylesBorins
test: improve test-gc-http-client-connaborted
6bea43c 
* refactor out usage of 'function' for scoping
* wait till server is up to start firing requests

PR-URL: #23193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@lundibundi lundibundi

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lundibundi @nodejs-github-bot @addaleax @jasnell @thefourtheye @lpinca @joyeecheung @BridgeAR