-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve test-gc-http-client-onerror #23196
Closed
Closed
+19
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
I think that might help with masking a real problem, see nodejs/reliability#18 (comment). |
* refactor out usage of 'function' for scoping * inline runTest function
lundibundi
force-pushed
the
improve-gc-http-onerror
branch
from
October 8, 2018 22:55
330c8e3
to
acddd91
Compare
lundibundi
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 8, 2018
Landed in 0ea804a |
addaleax
pushed a commit
that referenced
this pull request
Oct 12, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
* refactor out usage of 'function' for scoping * inline runTest function PR-URL: #23196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes