Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve instructions for verifying binaries #23248

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 3, 2018

Simplify and clarify the text in README.md for verifying binaries.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Simplify and clarify the text in README.md for verifying binaries.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 3, 2018
Current, LTS, and Nightly download directories all contain a SHASUMS256.txt
file that lists the SHA checksums for each file available for
download.
Download directories contain a SHASUMS256.txt file with SHA checksums for the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHASUMS256.txt -> `SHASUMS256.txt` (with backticks)?

(Here and in all other mentions of SHASUMS256.txt and SHASUMS256.txt.sig if it is appropriate for this PR).

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2018
@Trott
Copy link
Member Author

Trott commented Oct 6, 2018

Landed in 004f8b0

@Trott Trott closed this Oct 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 6, 2018
Simplify and clarify the text in README.md for verifying binaries.

PR-URL: nodejs#23248
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
Simplify and clarify the text in README.md for verifying binaries.

PR-URL: #23248
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
Simplify and clarify the text in README.md for verifying binaries.

PR-URL: #23248
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Oct 12, 2018
Simplify and clarify the text in README.md for verifying binaries.

PR-URL: nodejs#23248
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Simplify and clarify the text in README.md for verifying binaries.

PR-URL: #23248
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the verifyingb branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants