Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] build: update arm64 minimum supported platform #23275

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] build: update arm64 minimum supported platform #23275

wants to merge 1 commit into from

Conversation

tomleah
Copy link
Contributor

@tomleah tomleah commented Oct 5, 2018

Saw that #19164 needed a backport, PTAL
cc: @gibfahn @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v8.x labels Oct 5, 2018
@BethGriggs
Copy link
Member

ping @nodejs/build (I don't think editing the description pings)

@BethGriggs
Copy link
Member

BethGriggs commented Oct 30, 2018

Landed in 104fbc6

@BethGriggs BethGriggs closed this Oct 30, 2018
BethGriggs pushed a commit that referenced this pull request Oct 30, 2018
This is already true in practice.

Backport-PR-URL: #23275
PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants