zlib: move bytesRead accessors to runtime deprecation
#23308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves way for making `bytesRead` consistent with all other Node.js streams that provide a property with this name.
Trott
approved these changes
Oct 7, 2018
|
semver-major? |
addaleax
added
the
semver-major
|
CITGM for a getter/setter pair that |
lpinca
approved these changes
Oct 7, 2018
trivikr
approved these changes
Oct 7, 2018
cjihrig
approved these changes
Oct 7, 2018
doc/api/deprecations.md
Outdated
| @@ -2056,12 +2056,15 @@ core and obsoleted by the removal of NPN (Next Protocol Negotiation) support. | |||
| ### DEP0108: zlib.bytesRead | |||
| <!-- YAML | |||
| changes: | |||
| - version: REPLACEME | |||
| pr-url: https://github.com/nodejs/node/pull/REPLACEME | |||
jasnell
approved these changes
Oct 8, 2018
|
Landed in b2d8ae0 |
addaleax
added a commit
that referenced
this pull request
Oct 12, 2018
This paves way for making `bytesRead` consistent with all other Node.js streams that provide a property with this name. PR-URL: #23308 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This paves way for making `bytesRead` consistent with all other Node.js streams that provide a property with this name. PR-URL: #23308 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves way for making
bytesReadconsistent with all otherNode.js streams that provide a property with this name.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes