doc: remove style instruction that is not followed #23346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct.
|
@nodejs/documentation |
trivikr
approved these changes
Oct 9, 2018
thefourtheye
approved these changes
Oct 9, 2018
Trott
added
the
author ready
jasnell
approved these changes
Oct 9, 2018
ChALkeR
approved these changes
Oct 10, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: nodejs#23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
|
Landed in 120442a |
targos
pushed a commit
that referenced
this pull request
Oct 12, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: #23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: #23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: #23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: #23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: #23346 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove style guide instruction to place punctuation inside parentehses
and quotation marks. Those are not universally correct and we do not
follow those rules in cases where they are not correct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes