tools: update node-lint-md-cli-rollup #23358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2).
refack
approved these changes
Oct 10, 2018
I vendored it in to reduce the turnaround time on updates to rules (if the files are checked in we can update the rules independently of |
|
But don't you want to run it ( |
|
BTW: we don't (yet) have a regression test for the tool. I tested it manually, but that might be a nice chore... |
|
Just an observation (not blocking this) but this undoes parts of #23302 (13340d4#diff-e511e27e1719c62f08ee48fd97573087). It's not particularly obvious that |
|
We could add a preamble to the file... Or Uglify it... Again some interesting chores... |
targos
approved these changes
Oct 11, 2018
Trott
added
the
author ready
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: nodejs#23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 54ce229 |
targos
pushed a commit
that referenced
this pull request
Oct 12, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
4 tasks
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: #23358 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with
npm audit. It also updates remark-preset-lint-node to1.0.3 (from 1.0.2).
@refack This removes the md lint preset stuff from the filesystem and relies on the npm registry. Having it on the file system messed with
npm updateandnpm audit fixand othernpmcommands I ran trying to work around it. If you'd like to keep it in the repo, I'm happy to restore it that way. This seems simpler to me and (based on thenpmissues I just described) more robust. But just give me a quick explanation why you want it the way it was, and I'll restore it!Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes