test: refactor common.ddCommand() #23411

Trott · 2018-10-10T18:27:08Z

Remove different paths for Windows and POSIX.
Remove fixtures file. Simply run the command immediately/directly.
Since it is never called with more than one value for kilobytes,
eliminate that argument.
Update/simplify tests that use this function. (They no longer need to
use child_process to run the command.)
Update documentation.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation.

nodejs-github-bot · 2018-10-10T18:27:10Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1193/pipeline

Trott · 2018-10-10T18:27:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17726/

refack · 2018-10-10T18:36:21Z

test/common/index.js

-  } else {
-    return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`;
-  }
+function ddCommand(filename) {


Then why not call it createZeroFilledFile?

Because I'm lazy?

refack

1 nit

vsemozhetbyt · 2018-10-10T19:04:37Z

test/common/README.md


-Platform normalizes the `dd` command
+Creates a 10Mb file of all null characters.


Mb -> MB to not be confused with megabit?

richardlau · 2018-10-10T19:24:21Z

test/common/index.js

-  }
+function ddCommand(filename) {
+  const fd = fs.openSync(filename, 'w');
+  fs.ftruncateSync(fd, 10240 * 1024);


I think this should either be 10 * 1024 * 1024 (my preference) or 10485760.

richardlau · 2018-10-10T19:45:13Z

Two failures across the board:

test-fs-error-messages

The removed fixture is also referenced in

node/test/parallel/test-fs-error-messages.js

Line 35 in 484e4db

const existingFile2 = fixtures.path('create-file.js');

https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6012/console

14:31:01 not ok 551 parallel/test-fs-error-messages
14:31:01   ---
14:31:01   duration_ms: 0.157
14:31:01   severity: fail
14:31:01   exitcode: 1
14:31:01   stack: |-
14:31:01     assert.js:86
14:31:01       throw new AssertionError(obj);
14:31:01       ^
14:31:01     
14:31:01     AssertionError [ERR_ASSERTION]: Missing expected exception (validateError).
14:31:01         at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-fs-error-messages.js:228:10)
14:31:01         at Module._compile (internal/modules/cjs/loader.js:706:30)
14:31:01         at Object.Module._extensions..js (internal/modules/cjs/loader.js:717:10)
14:31:01         at Module.load (internal/modules/cjs/loader.js:604:32)
14:31:01         at tryModuleLoad (internal/modules/cjs/loader.js:543:12)
14:31:01         at Function.Module._load (internal/modules/cjs/loader.js:535:3)
14:31:01         at Function.Module.runMain (internal/modules/cjs/loader.js:759:12)
14:31:01         at startup (internal/bootstrap/node.js:303:19)
14:31:01         at bootstrapNodeJSCore (internal/bootstrap/node.js:866:3)

https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1011/21794/console

14:42:27 not ok 609 parallel/test-fs-error-messages
14:42:27   ---
14:42:27   duration_ms: 0.184
14:42:27   severity: fail
14:42:27   exitcode: 1
14:42:27   stack: |-
14:42:27     (node:42232) internal/test/binding: These APIs are exposed only for testing and are not tracked by any versioning system or deprecation process.
14:42:27     /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/test/parallel/test-fs-error-messages.js:214
14:42:27         assert.strictEqual(existingFile, err.path);
14:42:27                                              ^
14:42:27     
14:42:27     TypeError: Cannot read property 'path' of null
14:42:27         at validateError (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/test/parallel/test-fs-error-messages.js:214:42)
14:42:27         at /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/test/common/index.js:345:15
14:42:27         at FSReqCallback.oncomplete (fs.js:148:20)

test-module-loading

This PR makes test/common/index.js no longer require fixtures:
https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6012/console

14:35:28 not ok 2386 sequential/test-module-loading
14:35:28   ---
14:35:28   duration_ms: 0.263
14:35:28   severity: fail
14:35:28   exitcode: 1
14:35:28   stack: |-
14:35:28     { loaded: 'from child' }
14:35:28     { loaded: 'from child' }
14:35:28     b/c.js exit
14:35:28     load test-module-loading.js
14:35:28     load fixtures/b/d.js
14:35:28     load package/index.js
14:35:28     load fixtures/b/c.js
14:35:28     load fixtures/a.js
14:35:28     test index.js modules ids and relative loading
14:35:28     test index.js in a folder with a trailing slash
14:35:28     test cycles containing a .. path
14:35:28     test node_modules folders
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/foo.js
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/node_modules
14:35:28     /data/iojs/build/workspace/node_modules
14:35:28     /data/iojs/build/node_modules
14:35:28     /data/iojs/node_modules
14:35:28     /data/node_modules
14:35:28     /node_modules
14:35:28     
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/baz/index.js
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/baz/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/node_modules
14:35:28     /data/iojs/build/workspace/node_modules
14:35:28     /data/iojs/build/node_modules
14:35:28     /data/iojs/node_modules
14:35:28     /data/node_modules
14:35:28     /node_modules
14:35:28     
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/bar.js
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/node_modules
14:35:28     /data/iojs/build/workspace/node_modules
14:35:28     /data/iojs/build/node_modules
14:35:28     /data/iojs/node_modules
14:35:28     /data/node_modules
14:35:28     /node_modules
14:35:28     
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/baz/node_modules/asdf.js
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules/baz/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/fixtures/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/node_modules
14:35:28     /data/iojs/build/workspace/node-test-commit-linuxone/node_modules
14:35:28     /data/iojs/build/workspace/node_modules
14:35:28     /data/iojs/build/node_modules
14:35:28     /data/iojs/node_modules
14:35:28     /data/node_modules
14:35:28     /node_modules
14:35:28     
14:35:28     test name clashes
14:35:28     load custom file types with extensions
14:35:28     load custom file types that return non-strings
14:35:28     load order
14:35:28     assert.js:86
14:35:28       throw new AssertionError(obj);
14:35:28       ^
14:35:28     
14:35:28     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
14:35:28     + actual - expected ... Lines skipped
14:35:28     
14:35:28       {
14:35:28         'common/index.js': {
14:35:28     -     'common/fixtures.js': {},
14:35:28           'common/tmpdir.js': {}
14:35:28     ...
14:35:28         'fixtures/throws_error.js': {}
14:35:28       }
14:35:28         at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/sequential/test-module-loading.js:252:10)
14:35:28         at Module._compile (internal/modules/cjs/loader.js:706:30)
14:35:28         at Object.Module._extensions..js (internal/modules/cjs/loader.js:717:10)
14:35:28         at Module.load (internal/modules/cjs/loader.js:604:32)
14:35:28         at tryModuleLoad (internal/modules/cjs/loader.js:543:12)
14:35:28         at Function.Module._load (internal/modules/cjs/loader.js:535:3)
14:35:28         at Function.Module.runMain (internal/modules/cjs/loader.js:759:12)
14:35:28         at startup (internal/bootstrap/node.js:303:19)
14:35:28         at bootstrapNodeJSCore (internal/bootstrap/node.js:866:3)

richardlau

Test failures are related.

Trott · 2018-10-10T19:57:43Z

Ugh! At least one of those tests writes to the fixtures directory. 😞

Trott · 2018-10-10T20:05:14Z

Fixed all nits, and (I think) fixed the test problems.

CI: https://ci.nodejs.org/job/node-test-pull-request/17729/

Change common.ddCommand() to common.createZeroFilledFile().

Trott · 2018-10-10T20:07:19Z

Whoops, missed a nit. Now I think I got all the nits.

CI: https://ci.nodejs.org/job/node-test-pull-request/17730/

Trott · 2018-10-10T20:55:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17731/ ✔️

(Thanks, @refack!)

Trott · 2018-10-10T22:10:12Z

CI is green. Does this look good to you now, @richardlau?

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. PR-URL: nodejs#23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). PR-URL: nodejs#23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Trott · 2018-10-12T20:49:26Z

Landed in bcbb937...3d62d38

addaleax · 2018-10-12T22:32:45Z

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Trott · 2018-10-12T22:44:40Z

@addaleax Backport in #23630

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. PR-URL: nodejs#23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). PR-URL: nodejs#23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

* Remove different paths for Windows and POSIX. * Remove fixtures file. Simply run the command immediately/directly. * Since it is never called with more than one value for kilobytes, eliminate that argument. * Update/simplify tests that use this function. (They no longer need to use child_process to run the command.) * Update documentation. Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Change common.ddCommand() to common.createZeroFilledFile(). Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

Trott added the test Issues and PRs related to the tests. label Oct 10, 2018

refack reviewed Oct 10, 2018

View reviewed changes

refack approved these changes Oct 10, 2018

View reviewed changes

vsemozhetbyt reviewed Oct 10, 2018

View reviewed changes

richardlau approved these changes Oct 10, 2018

View reviewed changes

lpinca approved these changes Oct 10, 2018

View reviewed changes

richardlau requested changes Oct 10, 2018

View reviewed changes

fixup! test: refactor common.ddCommand()

fd0eb95

fixup! fixup! test: refactor common.ddCommand()

74bc7df

test: rename common.ddCommand()

d3d2bab

Change common.ddCommand() to common.createZeroFilledFile().

fixup! fixup! fixup! test: refactor common.ddCommand()

bf4f33c

refack approved these changes Oct 10, 2018

View reviewed changes

fixup! in module loader

c1f684d

richardlau approved these changes Oct 10, 2018

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2018

benjamingr approved these changes Oct 11, 2018

View reviewed changes

thefourtheye approved these changes Oct 11, 2018

View reviewed changes

jasnell approved these changes Oct 12, 2018

View reviewed changes

gdams approved these changes Oct 12, 2018

View reviewed changes

Trott closed this Oct 12, 2018

addaleax added the backport-requested-v10.x label Oct 12, 2018

Trott mentioned this pull request Oct 12, 2018

[v10.x backport] test: refactor common.ddCommand() #23630

Closed

targos added backported-to-v10.x and removed backport-requested-v10.x labels Oct 13, 2018

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

Trott deleted the dd branch January 13, 2022 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: refactor common.ddCommand() #23411

test: refactor common.ddCommand() #23411

Trott commented Oct 10, 2018

nodejs-github-bot commented Oct 10, 2018

Trott commented Oct 10, 2018

refack Oct 10, 2018

Trott Oct 10, 2018

refack left a comment

vsemozhetbyt Oct 10, 2018

richardlau Oct 10, 2018

richardlau commented Oct 10, 2018

richardlau left a comment

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018 •

edited

Loading

Trott commented Oct 10, 2018

Trott commented Oct 12, 2018

addaleax commented Oct 12, 2018

Trott commented Oct 12, 2018


		Platform normalizes the `dd` command
		Creates a 10Mb file of all null characters.

test: refactor common.ddCommand() #23411

test: refactor common.ddCommand() #23411

Conversation

Trott commented Oct 10, 2018

Checklist

nodejs-github-bot commented Oct 10, 2018

Trott commented Oct 10, 2018

refack Oct 10, 2018

Choose a reason for hiding this comment

Trott Oct 10, 2018

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

vsemozhetbyt Oct 10, 2018

Choose a reason for hiding this comment

richardlau Oct 10, 2018

Choose a reason for hiding this comment

richardlau commented Oct 10, 2018

richardlau left a comment

Choose a reason for hiding this comment

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018

Trott commented Oct 10, 2018 • edited Loading

Trott commented Oct 10, 2018

Trott commented Oct 12, 2018

addaleax commented Oct 12, 2018

Trott commented Oct 12, 2018

Trott commented Oct 10, 2018 •

edited

Loading