crypto: migrate to getOptions() #23562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating from process.binding('config') to getOptions() in crypto.js
nodejs-github-bot
added
the
crypto
jasnell
approved these changes
Oct 12, 2018
jasnell
added
the
code-and-learn
addaleax
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 13, 2018
gireeshpunathil
approved these changes
Oct 13, 2018
addaleax
approved these changes
Oct 13, 2018
trivikr
approved these changes
Oct 13, 2018
tniessen
approved these changes
Oct 16, 2018
addaleax
added
the
author ready
|
Can I have some advice on how to fix the failing tests? |
|
@nick-ng These should be unrelated to this PR, nothing to worry about… New Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17932/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17965/ |
|
Landed in 4e96845, thank you for your contribution! |
tniessen
pushed a commit
that referenced
this pull request
Oct 19, 2018
Migrating from process.binding('config') to getOptions() in crypto.js.
PR-URL: #23562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
Migrating from process.binding('config') to getOptions() in crypto.js.
PR-URL: #23562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from process.binding('config') to getOptions() in crypto.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes