Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: throw if functions used as constructors in node_crypto.cc #23582

Closed
wants to merge 1 commit into from
Closed

src: throw if functions used as constructors in node_crypto.cc #23582

wants to merge 1 commit into from

Conversation

bmacnaughton
Copy link
Contributor

Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@bmacnaughton
src: throw if functions used as constructors in node_crypto.cc
5d8db04 
Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@addaleax addaleax self-assigned this Oct 12, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17765/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2018
@addaleax addaleax mentioned this pull request Oct 12, 2018
Closed
4 tasks
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/1​77​87

@Trott
Copy link
Member

Trott commented Oct 13, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/1​7801 ✔️

thefourtheye
thefourtheye approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @TimothyGu as their TODO comments are cleared here.

@addaleax
Copy link
Member

Landed in 20b3698

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Oct 14, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@bmacnaughton @addaleax
src: throw if functions used as constructors in node_crypto.cc
20b3698 
Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.

PR-URL: #23582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@bmacnaughton @jasnell
src: throw if functions used as constructors in node_crypto.cc
b5f5585 
Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.

PR-URL: #23582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@addaleax addaleax

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bmacnaughton @addaleax @Trott @jasnell @thefourtheye @TimothyGu @cjihrig @gireeshpunathil @targos @nodejs-github-bot