Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: prevent multiple connection errors #23636

Merged
merged 1 commit into from
Oct 17, 2018
Merged

tls: prevent multiple connection errors #23636

merged 1 commit into from
Oct 17, 2018

Commits on Oct 17, 2018

  1. tls: prevent multiple connection errors 

    onConnectEnd(), which is called by TLSSocket, has a guard to
prevent being called multiple times, but it does not prevent the
OpenSSL error handler from being called, leading to multiple
error events. This commit adds that piece of missing logic.

PR-URL: nodejs#23636
Fixes: nodejs#23631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    b94ce57 View commit details
    Browse the repository at this point in the history