doc: improve README.md #23705
Closed
doc: improve README.md #23705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make text more concise and remove some use of passive voice.
vsemozhetbyt
approved these changes
Oct 17, 2018
thefourtheye
approved these changes
Oct 17, 2018
addaleax
approved these changes
Oct 17, 2018
README.md
Outdated
| @@ -608,7 +606,7 @@ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273 | |||
| See the section above on [Verifying Binaries](#verifying-binaries) for how to | |||
| use these keys to verify a downloaded file. | |||
|
|
|||
| Previous releases may also have been signed with one of the following GPG keys: | |||
| Other keys used to sign some previous releases include: | |||
There was a problem hiding this comment.
Re: include … we should be clear on whether this is an exhaustive list or not. The previous wording sounded to me like it is?
There was a problem hiding this comment.
Maybe I can remove include?: Other keys used to sign some previous releases:
lpinca
approved these changes
Oct 17, 2018
mmarchini
approved these changes
Oct 17, 2018
Trott
added
the
author ready
refack
approved these changes
Oct 18, 2018
|
Landed in 15c3366 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 19, 2018
Make text more concise and remove some use of passive voice. PR-URL: nodejs#23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
Make text more concise and remove some use of passive voice. PR-URL: #23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
Make text more concise and remove some use of passive voice. PR-URL: #23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Make text more concise and remove some use of passive voice. PR-URL: #23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Make text more concise and remove some use of passive voice. PR-URL: #23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Make text more concise and remove some use of passive voice. PR-URL: #23705 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make text more concise and remove some use of passive voice.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes