build: fix coverage generation #23769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
Coverage CI run to validate: https://ci.nodejs.org/view/Node.js%20Daily/job/node-test-commit-linux-coverage/806/ |
jasnell
approved these changes
Oct 19, 2018
|
Coverage CI was good and I'd like to fast track this to get our coverage builds green again |
|
Regular CI run: https://ci.nodejs.org/job/node-test-pull-request/18012/ |
refack
approved these changes
Oct 20, 2018
|
/CC @nodejs/build-files |
joyeecheung
approved these changes
Oct 20, 2018
|
Failure was known issue seen before, resumed build here: https://ci.nodejs.org/job/node-test-pull-request/18045/ |
gdams
approved these changes
Oct 22, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: nodejs#23769 Fixes: nodejs#23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
|
Landed as 9464e43 |
mhdawson
added a commit
that referenced
this pull request
Oct 22, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: #23769 Fixes: #23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
|
Arg, noticed I jumped the gun and the resume failed as well. Build of master to see if fails there consistently as well: https://ci.nodejs.org/job/node-test-commit-linux/22568/ |
|
This is the issue for the faliure -> #16601 here: test-fs-readfile-tostring-fail If the run in master fails, I'll look at creating a PR which marks the test as flaky. |
|
Build in master was ok. So I'm assuming that if I had resumed again, or rebased and run a new CI it would have passed. Sorry for having jumped the gun, but I think I'm ok to close this now. |
jasnell
pushed a commit
that referenced
this pull request
Oct 22, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: #23769 Fixes: #23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
2 tasks
|
This lands cleanly on v10.x but requires a backport for 8.x |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: #23769 Fixes: #23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: #23769 Fixes: #23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Changes in command line options for nyc resulted in the coverage target no longer working. Pin the major version of nyc and update the options to get it working again. PR-URL: #23769 Fixes: #23690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesbuild: fix coverage generation
Changes in command line options for nyc resulted in the
coverage target no longer working.
Pin the major version of nyc and update the options to
get it working again.
Fixes: #23690