doc: document nullptr comparisons in style guide #23805
Conversation
This documents existing practices.
addaleax
added
the
c++
|
I thought we agreed to adopt the C++ Core Guidelines exactly to close the omissions in the style guide, and have explicit and well reasoned guidelines. Could you provide reasons for this change? |
What is says in the PR description. It documents what we currently have. Preferring to document existing style before working on changes was also what was echoed as a sentiment in the last TSC meeting.
We agreed to link these documents since they provide meaningful guidelines. They do not match our current style in all cases; for those cases, we have this very document. |
|
|
||
| Use explicit comparisons to `nullptr` when testing pointers, i.e. | ||
| `if (foo == nullptr)` instead of `if (foo)` and | ||
| `foo != nullptr` instead of `!foo`. |
There was a problem hiding this comment.
For consistency, maybe make this if (foo != nullptr) and if (!foo).
addaleax
added
the
author ready
|
@refack This is, as the PR says, an existing practice that we follow. I can only speculate about the reasons why it was introduced, but it does follow the general “explicit is better than implicit” rule, and makes clear whether a check tests a pointer or a boolean. The origins of the rule definitely predate my time around here (and I’m not so sure about their relevance). @bnoordhuis might know. |
|
Landed in 24cb1f3. |
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices. PR-URL: #23805 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This documents existing practices.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes