src: fix missing deprecation assignment #23809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
fast-track
|
Please 👍 to fast-track |
|
Missing |
doc/api/deprecations.md
Outdated
| @@ -2247,6 +2247,21 @@ Type: Documentation-only (supports [`--pending-deprecation`][]) | |||
| Directly calling `process.binding('uv').errname(<val>)` is deprecated. | |||
| Please make sure to use [`util.getSystemErrorName()`][] instead. | |||
|
|
|||
| <a id="DEP0120"></a> | |||
| ### DEP0120: Windows Performance Counter Support | |||
| <!-- | |||
There was a problem hiding this comment.
Suggested change
| <!-- | |
| <!-- YAML |
There was a problem hiding this comment.
(I will fix DEP0119 in another PR with another similar nit).
vsemozhetbyt
added
the
author ready
3 tasks
cjihrig
approved these changes
Oct 22, 2018
lpinca
approved these changes
Oct 22, 2018
Co-Authored-By: jasnell <jasnell@gmail.com>
jasnell
added a commit
that referenced
this pull request
Oct 22, 2018
PR-URL: #23809 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 7f61b52 |
jasnell
added a commit
that referenced
this pull request
Oct 22, 2018
PR-URL: #23809 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the assignment when landing
This needs a fast-track for v11.0.0
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes