test: fix flaky test #23811
Closed
test: fix flaky test #23811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 21, 2018
lundibundi
approved these changes
Oct 22, 2018
| server.close(); | ||
| } | ||
|
|
||
| setImmediate(makeRemainingRequests); |
There was a problem hiding this comment.
Nit: I think we can simply call the function as it will just postpone itself anyway.
This commit fixes test-tls-set-secure-context.js. The test was making one long lasting HTTP connection, followed by a number of shorter lived connections. However, it was possible that the connections were not received in the desired order. This commit ensures that the long lasting connection is established before making any other connections.
lpinca
reviewed
Oct 22, 2018
| async function makeRemainingRequests() { | ||
| // Wait until the first request is guaranteed to have been handled. | ||
| if (!firstResponse) { | ||
| return setImmediate(makeRemainingRequests); |
There was a problem hiding this comment.
Can we use a dummy EventEmitter to emit an event when firstResponse is set instead of polling for it and call makeRemainingRequests when the event is emitted?
lpinca
approved these changes
Oct 22, 2018
2 tasks
lundibundi
added
the
author ready
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 24, 2018
This commit fixes test-tls-set-secure-context.js. The test was making one long lasting HTTP connection, followed by a number of shorter lived connections. However, it was possible that the connections were not received in the desired order. This commit ensures that the long lasting connection is established before making any other connections. PR-URL: nodejs#23811 Fixes: nodejs#23807 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in b794f58. @lpinca Regarding your comment: Nit that can be ignored? Or something that should be done in a subsequent PR? If more than a nit, you'll open the PR? |
|
Yes, it can be ignored or addressed in another PR. Thank you. |
targos
pushed a commit
that referenced
this pull request
Oct 24, 2018
This commit fixes test-tls-set-secure-context.js. The test was making one long lasting HTTP connection, followed by a number of shorter lived connections. However, it was possible that the connections were not received in the desired order. This commit ensures that the long lasting connection is established before making any other connections. PR-URL: #23811 Fixes: #23807 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes
test-tls-set-secure-context.js. The test was making one long lasting HTTP connection, followed by a number of shorter lived connections. However, it was possible that the connections were not received in the desired order. This commit ensures that the long lasting connection is established before making any other connections.Fixes: #23807
Before this change, the command
tools/test.py -j 8 --repeat 1000 test/parallel/test-tls-set-secure-context.jsfailed approximately 1% of the time for me locally. With this change, I haven't seen a failure after two such runs.cc: @targos
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes