Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add documentation for http.IncomingMessage$complete #23914

Closed
wants to merge 2 commits into from
Closed

doc: add documentation for http.IncomingMessage$complete #23914

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 26, 2018

Fixes: #8102

Closing issues from 2016...

Checklist

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1384/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 26, 2018
@jasnell jasnell requested a review from apapirovski October 26, 2018 22:11
vsemozhetbyt
vsemozhetbyt reviewed Oct 27, 2018
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@vsemozhetbyt @jasnell
[Squash] suggestion
2b953e1 
Co-Authored-By: jasnell <jasnell@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2018

Ping @nodejs/documentation

jasnell added a commit that referenced this pull request Oct 30, 2018
@jasnell
doc: add documentation for http.IncomingMessage$complete
bd8c107 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2018

Landed in bd8c107

@jasnell jasnell closed this Oct 30, 2018
targos pushed a commit that referenced this pull request Nov 1, 2018
@jasnell @targos
doc: add documentation for http.IncomingMessage$complete
24c6a02 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jasnell @MylesBorins
doc: add documentation for http.IncomingMessage$complete
3c46c03 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jasnell @MylesBorins
doc: add documentation for http.IncomingMessage$complete
f0bbe9b 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add documentation for http.IncomingMessage$complete
6d76f85 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add documentation for http.IncomingMessage$complete
893239b 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: add documentation for http.IncomingMessage$complete
c68aab1 
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

@apapirovski apapirovski Awaiting requested review from apapirovski

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @lpinca @vsemozhetbyt @trivikr @MylesBorins