Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make example more clarified in cluster.md #23931

Closed
wants to merge 3 commits into from
Closed

doc: make example more clarified in cluster.md #23931

wants to merge 3 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 28, 2018 •
edited
Loading

Make example explanation more clarified in cluster Event:'message'.

Refs: #23930

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Oct 28, 2018
Trott
Trott requested changes Oct 28, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new sentence, clarify in the existing sentence?:

Here is a cluster that uses the message system to keep a count in the master
process of the number of HTTP requests received by the workers:

@Trott
Copy link
Member

Trott commented Oct 28, 2018

Or maybe even better, split into two sentences:

Here is an example using the message system. It keeps a count in the master
process of the number of HTTP requests received by the workers:

@ZYSzys
Copy link
Member Author

ZYSzys commented Oct 28, 2018

How about now ?

Trott
Trott reviewed Oct 28, 2018
View reviewed changes
doc/api/cluster.md Outdated
process of the number of HTTP requests received by the workers:

Note that when this example running, you need to open browser and visit `http://localhost:8000`
or open another terminal window and run `curl http://localhost:8000` to see `numReqs` increasing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the new sentence is necessary with the changes to the existing sentence.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1400/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2018
@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2018
@trivikr
Copy link
Member

trivikr commented Oct 29, 2018

Landed in 2061843

@trivikr trivikr closed this Oct 29, 2018
trivikr pushed a commit that referenced this pull request Oct 29, 2018
@ZYSzys @trivikr
doc: make example more clarified in cluster.md
2061843 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@ZYSzys ZYSzys deleted the cluster branch October 29, 2018 05:35
targos pushed a commit that referenced this pull request Nov 1, 2018
@ZYSzys @targos
doc: make example more clarified in cluster.md
64c205d 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@ZYSzys @MylesBorins
doc: make example more clarified in cluster.md
c0649c8 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@ZYSzys @MylesBorins
doc: make example more clarified in cluster.md
8d8ea4c 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
doc: make example more clarified in cluster.md
27b3583 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
doc: make example more clarified in cluster.md
0a2bc74 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@ZYSzys @MylesBorins
doc: make example more clarified in cluster.md
6099f5c 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ZYSzys @Trott @vsemozhetbyt @trivikr @thefourtheye @lpinca @hiroppy @MylesBorins @nodejs-github-bot