Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typographical suggestions #23970

Closed
wants to merge 1 commit into from
Closed

Typographical suggestions #23970

wants to merge 1 commit into from

Conversation

denismcdonald
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 30, 2018
@Trott
Copy link
Member

Trott commented Oct 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1419/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 30, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Oct 30, 2018
View reviewed changes
doc/api/synopsis.md Show resolved Hide resolved
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 30, 2018
pull bot pushed a commit to SimenB/node that referenced this pull request Oct 30, 2018
@denismcdonald @vsemozhetbyt
doc: fix typographical issues
6f4721b 
PR-URL: nodejs#23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 6f4721b
Thank you!

@refack
Copy link
Contributor

refack commented Oct 30, 2018

Hello @denismcdonald and thank you for the contribution.
I have a few questions for you regarding your experience submitting this PR. Are you available?

@denismcdonald
Copy link
Contributor Author

Hi there, @refack. Sure, how can I help?

@refack
Copy link
Contributor

refack commented Oct 31, 2018

Hello @denismcdonald,
I was wondering if while submitting the PR, our contribution guide was accessible, and easy to understand?
Some was complained that it's too long, or that the references are obscure. What was your experience?

@denismcdonald
Copy link
Contributor Author

Because of the nature of my PR, Refael (i.e., simply typographical, and relating only to the Node documentation), I don't think I can comment either way, I'm afraid.

Perhaps the only thing I could note (if it's of any use in improving the docs' "Edit on GitHub" process) is that I don't believe I was alerted, when submitting the PR, to the fact that a style guide existed for the docs, against which I could check any amendments I was suggesting. For it's only now, through you mentioning the contribution guide, that I see that a style guide does exist. But again, because the typographical errors I noticed were straightforward, it's not as though I was seeking guidance in that respect.

(Bear in mind, by the way, that I'm a Node beginner, and not experienced in submitting PRs, so perhaps I should apologise if I overlooked any requirements in submitting even a PR of this nature!)

@denismcdonald denismcdonald deleted the patch-1 branch October 31, 2018 02:34
@refack
Copy link
Contributor

refack commented Oct 31, 2018

Bear in mind, by the way, that I'm a Node beginner, and not experienced in submitting PRs, so perhaps I should apologise if I overlooked any requirements in submitting even a PR of this nature!

Above all, I'd like to thank you for the contribution! 🥇 IMHO there is no need to apologize whatsoever.

Perhaps the only thing I could note (if it's of any use in improving the docs' "Edit on GitHub" process) is that I don't believe I was alerted

That's great feedback. Exactly what I was looking for. Thank you for that as well.

Hope we see you contribution more in the future. If you have any questions, feel free to contact me directly.

@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2018
@refack refack mentioned this pull request Oct 31, 2018
Closed
targos pushed a commit that referenced this pull request Nov 1, 2018
@denismcdonald @targos
doc: fix typographical issues
cc65fee 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@denismcdonald @MylesBorins
doc: fix typographical issues
1c9ae77 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@denismcdonald @MylesBorins
doc: fix typographical issues
48ce4a0 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@denismcdonald @rvagg
doc: fix typographical issues
73e0bb1 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@denismcdonald @rvagg
doc: fix typographical issues
3d8d919 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@denismcdonald @MylesBorins
doc: fix typographical issues
f54f640 
PR-URL: #23970
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@denismcdonald @Trott @vsemozhetbyt @refack @jasnell @lpinca @cjihrig @richardlau @MylesBorins @nodejs-github-bot