Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove useless getLibuvNow in internal/timers #23995

Closed
wants to merge 1 commit into from
Closed

lib: remove useless getLibuvNow in internal/timers #23995

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 31, 2018

Remove unused getLibuvNow in lib/internal/timers.js since we are using this function through internalBinding('timers') directly in lib/timers.js.
Maybe make bit of optimization ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 31, 2018
@Trott
Copy link
Member

Trott commented Nov 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18308/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2018
@Trott
Copy link
Member

Trott commented Nov 4, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18323/

@Trott
Copy link
Member

Trott commented Nov 4, 2018

Landed in 22f5c08

@Trott Trott closed this Nov 4, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 4, 2018
@ZYSzys @Trott
lib: remove useless getLibuvNow in internal/timers
22f5c08 
PR-URL: nodejs#23995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@ZYSzys ZYSzys deleted the internal/timers branch November 4, 2018 02:18
targos pushed a commit that referenced this pull request Nov 5, 2018
@ZYSzys @targos
lib: remove useless getLibuvNow in internal/timers
874393b 
PR-URL: #23995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ZYSzys @Trott @jasnell @addaleax @lpinca @cjihrig @mmarchini @ryzokuken @codebytere @nodejs-github-bot