-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps/npm: Use print() function on both Python 2 and 3 #24487
Conversation
5270045
to
60520e0
Compare
60520e0
to
85f9795
Compare
Changes to deps need to be landed upstream. We cannot land changes like this without them landing there first. |
Thanks @jasnell but what exactly is upstream for deps/npm? https://github.com/npm/npm moved to https://github.com/npm/cli but that repo contains no Python code. |
The upstream here would be |
To resolve this we need to release a new version of Lines 1228 to 1231 in 4327326
|
@cclauss I'm going to close this issue as P.S. thank you very much for the effort! |
P.S. 🤣 just found openssl/openssl@83e4533#diff-96834629132c625c44b0d575f898c511 |
A subset of #23669 to simplify the review process. @refack @addaleax
The openssl change was merged into upstream in openssl/openssl#7409
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes