Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update remark-preset-lint-node to v1.3.1 #24642

Closed
wants to merge 2 commits into from
Closed

tools: update remark-preset-lint-node to v1.3.1 #24642

wants to merge 2 commits into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Nov 25, 2018

Summary
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@watilde build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1701/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 25, 2018
@Trott
Copy link
Member

Trott commented Nov 25, 2018

There are two .md files with trailing spaces that will need to be fixed before this lands. One is the README and the other is a CHANGELOG file if I recall correctly.

@Trott
Copy link
Member

Trott commented Nov 25, 2018

(The fix for the trailing spaces can happen in this PR itself. Probably best as a first commit and then the update of the presets as a second commit.)

@watilde
Copy link
Member Author

watilde commented Nov 25, 2018

I agree. Will arrange the commits and let me ping you when it's done.

refack
refack approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@refack
Copy link
Contributor

refack commented Nov 25, 2018

ATM the linter complains only about

README.md
  65:18  warning  Remove trailing whitespace  no-trailing-spaces  remark-lint
⚠ 1 warning

@refack refack added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Nov 25, 2018
@watilde watilde force-pushed the feature/update-remark-preset branch from 892664d to 6b19147 Compare November 26, 2018 02:37
@watilde
Copy link
Member Author

watilde commented Nov 26, 2018

I removed trailing whitespace in readme and ci gets green🥗 @Trott

@Trott
Copy link
Member

Trott commented Nov 26, 2018

Can you re-arrange the commits so that the doc change is first and the update to the plugin is second? (Or squash them into a single commit, although I prefer them separate for ease of backporting.) The way it is now, make lint fails on the first commit. That could be irksome while bisecting, for example.

@watilde
Copy link
Member Author

watilde commented Nov 26, 2018

This is what I did already :)

Can you re-arrange the commits so that the doc change is first and the update to the plugin is second?

@Trott
Copy link
Member

Trott commented Nov 28, 2018

This is what I did already :)

I am easily confused, apparently. :-D

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1705/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Landed in f351c5d...8ce0d4f

@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@watilde @Trott
doc: remove trailing whitespace
d0bf5ca 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@watilde @Trott
tools: update remark-preset-lint-node to v1.3.1
8ce0d4f 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 28, 2018
@watilde @targos
doc: remove trailing whitespace
8e37905 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 28, 2018
@watilde @targos
tools: update remark-preset-lint-node to v1.3.1
e217d81 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 28, 2018
Closed
@watilde watilde deleted the feature/update-remark-preset branch November 29, 2018 05:11
targos pushed a commit that referenced this pull request Nov 30, 2018
@watilde @targos
doc: remove trailing whitespace
654bd65 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 30, 2018
@watilde @targos
tools: update remark-preset-lint-node to v1.3.1
e7fbdf5 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@watilde @refack
doc: remove trailing whitespace
61fed75 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@watilde @refack
tools: update remark-preset-lint-node to v1.3.1
691c9cb 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@fhinkel fhinkel fhinkel approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watilde @nodejs-github-bot @Trott @refack @fhinkel @targos @BethGriggs