Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: check for git tag before promoting release #24670

Closed
wants to merge 1 commit into from
Closed

tools: check for git tag before promoting release #24670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tools/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ fi
echo "Using GPG key: $gpgkey"
echo " Fingerprint: $gpgfing"

function checktag {
local version=$1

if ! git tag -v $version 2>&1 | grep "${gpgkey}" | grep key > /dev/null; then
echo "Could not find signed tag for \"${version}\" or GPG key is not yours"
exit 1
fi
}

################################################################################
## Create and sign checksums file for a given version
Expand All @@ -90,11 +98,6 @@ function sign {

local version=$1

if ! git tag -v $version 2>&1 | grep "${gpgkey}" | grep key > /dev/null; then
echo "Could not find signed tag for \"${version}\" or GPG key is not yours"
exit 1
fi

ghtaggedversion=$(curl -sL https://raw.githubusercontent.com/nodejs/node/${version}/src/node_version.h \
| awk '/define NODE_(MAJOR|MINOR|PATCH)_VERSION/{ v = v "." $3 } END{ v = "v" substr(v, 2); print v }')
if [ "${version}" != "${ghtaggedversion}" ]; then
Expand Down Expand Up @@ -150,7 +153,8 @@ function sign {


if [ -n "${signversion}" ]; then
sign ${signversion}
checktag $signversion
sign $signversion
exit 0
fi

Expand Down Expand Up @@ -192,6 +196,8 @@ for version in $versions; do
continue
fi

checktag $version

echo -e "\n# Promoting ${version}..."

ssh ${customsshkey} ${webuser}@${webhost} $promotecmd nodejs $version
Expand Down