Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] doc: sort bottom-of-file markdown links #24682

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] doc: sort bottom-of-file markdown links #24682

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

Backport of #24679

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Nov 27, 2018
@sam-github sam-github changed the title doc: sort bottom-of-file markdown links [v8.x backport] doc: sort bottom-of-file markdown links Nov 27, 2018
@sam-github sam-github mentioned this pull request Nov 27, 2018
Closed
4 tasks
@vsemozhetbyt
Copy link
Contributor

Does this need rebasing?

@sam-github sam-github force-pushed the backport-24679-to-v8.x branch from fa6e71a to cdea42e Compare November 28, 2018 17:16
@sam-github
Copy link
Contributor Author

PTAL

vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
doc/api/cluster.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
doc/api/tls.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 2 nits.

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@sam-github
Copy link
Contributor Author

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1727/

@sam-github
Copy link
Contributor Author

@nodejs/lts can you merge this to staging before it collects more conflicts? pls.

rvagg pushed a commit that referenced this pull request Dec 1, 2018
@sam-github @rvagg
doc: sort bottom-of-file markdown links
ffe1f80 
Backport of #24679

PR-URL: #24682
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@rvagg
Copy link
Member

rvagg commented Dec 1, 2018

👍 done ffe1f80

@rvagg rvagg closed this Dec 1, 2018
@sam-github sam-github deleted the backport-24679-to-v8.x branch December 3, 2018 04:27
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @rvagg