test: improve the WPT runner and rename test files #24826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter.
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ```
|
cc @nodejs/testing @nodejs/url |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19262/ |
|
Failure looks related? /home/iojs/build/workspace/node-test-commit-linux-containered/test/common/wpt.js:451
reason: reasons.join('; ')
^
TypeError: reasons.join is not a function
at WPTRunner.skip (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/wpt.js:451:23)
at WPTRunner.buildQueue (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/wpt.js:503:14)
at WPTRunner.runJsTests (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/wpt.js:265:20)
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-url.js:19:8)
at Module._compile (internal/modules/cjs/loader.js:723:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:734:10)
at Module.load (internal/modules/cjs/loader.js:620:32)
at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
at Function.Module._load (internal/modules/cjs/loader.js:552:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:776:12) |
|
(Probably there are some loopholes in the logic for a nointl build, I'll investigate) |
|
This should fix the nointl failure. CI: https://ci.nodejs.org/job/node-test-pull-request/19539/ ✔️ |
watilde
approved these changes
Dec 14, 2018
joyeecheung
added
author ready
|
Landed in 87006be...b520254 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: #24826 Refs: #24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: #24826 Refs: #24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of porting other parts of WPT into
test/wpt(I am currently working on performance-timeline and encoding).test: remove reference to whatwg in file names under test/wpt
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.
Refs: #24823
test: improve WPT runner name matching
This patch:
encoding where all the tests requires i18n support in the build)
properties from
globalinstead of the givenobj)Previously an expected failure is printed as
Now it is printed as
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes