Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: extract validateObject validator #24920

Closed
wants to merge 3 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 9, 2018

Pulls out the common argument validateObject validator to internal/validators.

BTW, there is inconsistent ERR_INVALID_ARG_TYPE via the object validation: object or Object, do we need to unify this error message ? Although this is so trivial :)

throw new ERR_INVALID_ARG_TYPE('pathObject', 'Object', pathObject);

throw new ERR_INVALID_ARG_TYPE('args', 'object', args);

Update: unify the error message by lowercase object(should be semver-major?)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. crypto Issues and PRs related to the crypto subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 9, 2018
@mscdex
Copy link
Contributor

mscdex commented Dec 9, 2018

FWIW this conflicts with #24913

@ZYSzys ZYSzys force-pushed the validate-object branch 2 times, most recently from 1ee3fd6 to c05eb83 Compare December 24, 2018 14:34
@ZYSzys ZYSzys force-pushed the validate-object branch 2 times, most recently from 5837b1f to 1e8929d Compare December 24, 2018 15:56
@ofrobots ofrobots removed the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Feb 14, 2019
@ZYSzys ZYSzys closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants