test: added test for lib/internal/util/inspector.js

[IlarionHalushka]

Test for lib/internal/util/inspector.js to make 100% test coverage.
Test checks that onError on line 19 is executed when exception is thrown

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[Trott]

Looks like you forgot the util part of the path in the commit message/PR description?

root is an artifact of the coverage reporting and does not exist. It's lib. There is no lib/internal/inspector.js. Looks like you mean lib/internal/util/inspector.js.

(This all can be fixed by whoever lands the PR, but if you can fix it in the commit and force push it, all the better to save someone else a bit of editing.)

[Trott]

common.mustCall() does not take a string argument. If you're intention here is to throw an error, use () => { throw new Error('foo'); } or something like that instead.

[Trott]

I'd prefer something that used the public APIs to trigger the error, but this will do in its absence!

[Trott]

And thanks for the pull request!

[IlarionHalushka]

@Trott Thanks for the review. I made the changes that you requested.

review comments addressed

[lpinca]

CI: https://ci.nodejs.org/job/node-test-pull-request/21418/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22051/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22357/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22796/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22822/

[Trott]

There are some relevant failures in CI. It's because the inspector tests all need to be skipped if node is compiled without certain things. Can you add a line that calls common.skipIfInspectorDisabled(); like you'll see in the other test-inspector-* files?

[gireeshpunathil]

@IlarionHalushka - can you pls address the review comments?

[IlarionHalushka]

There is no catch in sendInspectorCommand anymore. Closing PR.