assert: inspect getters #25004
assert: inspect getters #25004
Conversation
While asserting two objects the descriptor is not taken into account. Therefore getters will be triggered as such. This makes sure they are also highlighted in the error message instead of potentially looking identical while the return value of the getter is actually different.
nodejs-github-bot
added
the
assert
|
@nodejs/assert PTAL |
|
This could conceivably make tests fail where they currently succeed. In many cases, that's probably more of a bugfix than a breaking change. But not all, I don't think. This is the internal conversation I'm having with myself that has prevented me from approving this up until now. It looks good to me, but I wonder. Is a CITGM run a good idea here? |
|
@Trott I am sorry but I am not sure I can follow. Do you mean a test that checks the assertion message? We changed that multiple times so far and I am not aware of any issues about that (anymore). Just so we are aligned: the actual comparison is not changed here at all. That comparison already triggers the getters and it's just the error output which is changed. |
BridgeAR
added
the
author ready
|
Resumed build https://ci.nodejs.org/job/node-test-pull-request/19616/ |
|
Resume Build had 100% failure on fanned jobs, which I'm guessing is because something cached got dropped from Jenkins. CI: https://ci.nodejs.org/job/node-test-pull-request/19634/ (scheduled) |
|
Landed in 3b2698e |
While asserting two objects the descriptor is not taken into account. Therefore getters will be triggered as such. This makes sure they are also highlighted in the error message instead of potentially looking identical while the return value of the getter is actually different. PR-URL: nodejs#25004 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
While asserting two objects the descriptor is not taken into account. Therefore getters will be triggered as such. This makes sure they are also highlighted in the error message instead of potentially looking identical while the return value of the getter is actually different. PR-URL: #25004 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
While asserting two objects the descriptor is not taken into account. Therefore getters will be triggered as such. This makes sure they are also highlighted in the error message instead of potentially looking identical while the return value of the getter is actually different. PR-URL: nodejs#25004 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes