Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] http: fix regression of binary upgrade response body #25037

Closed
wants to merge 1 commit into from
Closed

[8.x] http: fix regression of binary upgrade response body #25037

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1944/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v8.x labels Dec 14, 2018
@mcollina
Copy link
Member Author

cc @MylesBorins @nodejs/lts

@mcollina
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19515/

@mcollina mcollina changed the title http: fix regression of binary upgrade response body [8.x] http: fix regression of binary upgrade response body Dec 14, 2018
@lpinca lpinca mentioned this pull request Dec 14, 2018
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Dec 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19521/

@Trott
Copy link
Member

Trott commented Dec 14, 2018

sequential/test-http2-settings-flood failed on same Windows variant both CI runs. Wouldn't think it's relevant, but maybe? Or maybe it's flaky on v8.x?

@Trott
Copy link
Member

Trott commented Dec 14, 2018 •
edited
Loading

Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/19525/ ✔️

@mcollina
Copy link
Member Author

It's definitely not relevant.

MylesBorins
MylesBorins approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
a947b75 
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

landed in a947b75

@mcollina mcollina deleted the 8-remove-spurious-http-fix branch December 21, 2018 16:29
MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
f31dc1b 
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 22, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
215ecfe 
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Dec 26, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcollina @nodejs-github-bot @Trott @MylesBorins