Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] http: fix regression of binary upgrade response body #25039

Closed
wants to merge 1 commit into from
Closed

[10.x] http: fix regression of binary upgrade response body #25039

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Fixes: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1945/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v10.x labels Dec 14, 2018
@mcollina mcollina changed the base branch from v10.x-staging to v10.x December 14, 2018 11:49
@mcollina
Copy link
Member Author

mcollina commented Dec 14, 2018 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19516/ ✔️

@mcollina
Copy link
Member Author

cc @MylesBorins @nodejs/lts

@lpinca lpinca mentioned this pull request Dec 14, 2018
Closed
2 tasks
@Trott Trott mentioned this pull request Dec 14, 2018
Closed
MylesBorins
MylesBorins approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
c5140f5 
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

landed in c5140f5

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
8c6e7f5 
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 22, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
19eb4e4 
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 22, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
8958650 
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@mcollina @MylesBorins
http: fix regression of binary upgrade response body
1aea1e3 
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Dec 26, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollina @nodejs-github-bot @MylesBorins