-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: mark some global state as const #25052
Conversation
Mark some global variables as `const` or `constexpr`.
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19551/ |
Windows CI failures related? |
One red CI failure on AIX is not something I've seen before, or not seen much of anyway, but it looks like it's caused by the same thing as the other child-process failures in tests. Opened #25068 to track it but in the meantime: Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19567/ |
New failure is not seen before recently and appears to be caused by the same bug as other recent CI failures. Opened an issue for it: #25070 Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19571/ ✔️ |
Landed in 18f2bf7 |
Mark some global variables as `const` or `constexpr`. PR-URL: nodejs#25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Mark some global variables as `const` or `constexpr`. PR-URL: #25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Mark some global variables as `const` or `constexpr`. PR-URL: nodejs#25052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Mark some global variables as
const
orconstexpr
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes