Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: improve inspectOptions validation #25090

Merged
merged 1 commit into from
Dec 19, 2018
Merged

console: improve inspectOptions validation #25090

merged 1 commit into from
Dec 19, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2018

This commit adds stricter type checking to the inspectOptions option to the Console constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1981/pipeline

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Dec 17, 2018
@Trott
Copy link
Member

Trott commented Dec 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19628/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 18, 2018
@cjihrig
console: improve inspectOptions validation
bf36f07 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: nodejs#25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit bf36f07 into nodejs:master Dec 19, 2018
@cjihrig cjihrig deleted the console branch December 19, 2018 17:21
@MylesBorins
Copy link
Contributor

This does not land cleanly on v11.x, would someone be willing to backport?

@targos
Copy link
Member

targos commented Jan 1, 2019

Depends on #24978

BridgeAR pushed a commit that referenced this pull request Jan 10, 2019
@cjihrig @BridgeAR
console: improve inspectOptions validation
049b24d 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member

Backported directly to the staging branch due to recent console backports.

addaleax pushed a commit that referenced this pull request Jan 14, 2019
@cjihrig @addaleax
console: improve inspectOptions validation
272ddb1 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
console: improve inspectOptions validation
5614814 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: nodejs#25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @Trott @MylesBorins @targos @BridgeAR @jasnell @antsmartian @lpinca @BethGriggs