Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: move child process IPC setup condition into node.js #25130

Closed
wants to merge 1 commit into from
Closed

process: move child process IPC setup condition into node.js #25130

wants to merge 1 commit into from

Commits on Dec 19, 2018

  1. process: move child process IPC setup condition into node.js 

    Instead of branching in main_thread_only.js, move the branch on
process.env.NODE_CHANNEL_FD in node.js so it's easier to tell when
this needs to happen. Also added comments about what side effect
this causes, and lazy load `assert`.
    @joyeecheung
    joyeecheung committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    b607c1c View commit details
    Browse the repository at this point in the history