Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: reduce redundant callback check #25160

Closed
wants to merge 1 commit into from
Closed

fs: reduce redundant callback check #25160

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 21, 2018 •
edited
Loading

If options is a function, we don't need to call maybeCallback to check it again.

node/lib/fs.js

Lines 130 to 135 in 4ac1702

function maybeCallback(cb) {
if (typeof cb === 'function')
return cb;
throw new ERR_INVALID_CALLBACK();
}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Dec 21, 2018
@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20696/

@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

Landed in e34d41e.

@lpinca lpinca closed this Feb 9, 2019
lpinca pushed a commit that referenced this pull request Feb 9, 2019
@ZYSzys @lpinca
fs: remove redundant callback check
e34d41e 
PR-URL: #25160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ZYSzys ZYSzys deleted the fs-redundant-check branch February 10, 2019 06:45
targos pushed a commit that referenced this pull request Feb 10, 2019
@ZYSzys @targos
fs: remove redundant callback check
2b48a38 
PR-URL: #25160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZYSzys @lpinca @jasnell @nodejs-github-bot