Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] test: mark test-repl-envvars as flaky on AIX #25219

Closed
Closed
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
91b8c5b
src: remove function hasTextDecoder in encoding.js
chichiwang Oct 12, 2018
acd7312
crypto: reduce memory usage of SignFinal
tniessen Oct 11, 2018
22ee1e3
zlib: do not leak on destroy
mafintosh Oct 18, 2018
c00a830
src: memory management using smart pointer
uttampawar Oct 12, 2018
e8200c0
src: simplify `TimerFunctionCall()` in `node_perf.cc`
addaleax Oct 20, 2018
93d4163
tls: throw if protocol too long
Oct 12, 2018
50b22de
doc, test: document and test vm timeout escapes
jasnell Oct 18, 2018
83888e8
test: mark test-vm-timeout-* known issue tests flaky
jasnell Oct 24, 2018
9df556c
build: expose more openssl categories for addons
JCMais Oct 9, 2018
784f1a0
src: avoid extra `Persistent` in `DefaultTriggerAsyncIdScope`
addaleax Oct 24, 2018
1156606
src: cache the result of GetOptions() in JS land
joyeecheung Nov 4, 2018
2ff9143
build: only try to find node when it's needed by the target
joyeecheung Nov 6, 2018
c85c2ce
test: http-client-timeout error assert arguments
rangle-tadhg Nov 6, 2018
a4620ab
test: fix arguments order
franher Nov 6, 2018
abf575d
child_process: allow 'http_parser' monkey patching again
Jimbly Oct 31, 2018
4ca0134
test: fs readfile, swap arguments in strictEqual
dodev Nov 6, 2018
9dbe096
test: swap the order of arguments
mhamwala Nov 6, 2018
71a61dd
test: strictEqual argument order (actual, expected)
Nov 6, 2018
c769b8b
test: fix invalid argument order in test-http-expect-continue.js
mroderick Nov 6, 2018
7574f3f
test: change order of assert.strictEqual()
remypar5 Nov 6, 2018
27cb911
test: fix assert parameter order
Nov 6, 2018
e06bb47
test: swap expected and actual in assert.strictEqual
fbilbie Nov 6, 2018
84a9ba4
test: add tests for OutgoingMessage setTimeout
robin-drexler Nov 6, 2018
d175a2e
test: fixing arguments order in `assert.strictEqual()`
gcarcaci Nov 6, 2018
d9489e1
test: fixe argument order in assert.strictEqual
posth Nov 6, 2018
1d88f01
test: fix arguments order
simonaco Nov 6, 2018
88231ca
test: switch arguments in strictEqual
mthpvg Nov 6, 2018
a7f604a
test: fix argument order in assert.strictEqual()
Nov 6, 2018
30d9588
test: fix arguments order in test-fs-write-buffer
razvanbh Nov 6, 2018
040ed21
test: removed extraneous argument 's'
jacksonchui Nov 7, 2018
0e5fe9a
test: fix assert argument order
manishepoch Nov 6, 2018
561ac4c
test: fix arguments order in assert.strictEqual
Nov 6, 2018
ee821b4
test: fix order in assert.strictEqual to actual, expected
Nov 6, 2018
56edd9f
test: fix the arguments order in `assert.strictEqual`
michael-zucker Nov 7, 2018
52f3ecc
test: fix the arguments order in `assert.strictEqual`
michael-zucker Nov 7, 2018
042e379
doc: fix some inconsistent use of hostname
sam-github Nov 6, 2018
81ff70d
test: switch order of strictEqual arguments
jpolack Nov 6, 2018
b264d7e
test: change arguments order in strictEqual
Paul-Isache Nov 6, 2018
f657e40
buffer: fix writeUInt16BE range check
mscdex Nov 6, 2018
c2f7f26
test: fix order of arguments in test-delayed-require assertion
reineke-fox Nov 6, 2018
d6f6c62
test: add error code tests in dgram test
MarkArranz Nov 7, 2018
0056c08
url: make the context non-enumerable
joyeecheung Nov 7, 2018
8c59ebb
benchmark: support more options in startup benchmark
joyeecheung Nov 6, 2018
d35739d
doc: describe what tls servername is for
sam-github Nov 7, 2018
2de3376
src: reuse std::make_unique
alyssaq Nov 6, 2018
64f7622
test: fix NewFromUtf8 compiler warning
danbev Nov 7, 2018
bb871c9
test: add coverage for escape key switch case
Nov 6, 2018
f50beda
test: add test for 'ERR_INVALID_CALLBACK'
razvanbh Nov 7, 2018
802d4b8
doc: fix code examples in stream.md
grantcarthew Nov 5, 2018
5dec2ca
tracing: fix static destruction order issue
addaleax Nov 6, 2018
9f023c4
test: fix order of arguments in assert.strictEqual
eiskalteschatten Nov 6, 2018
36861ad
test: add coverage for systemerror set name
amer8 Nov 6, 2018
899245f
test: add test for strictDeepEqual
nikita-malyschkin Nov 7, 2018
8209ecd
test: use assert.strictEqual instead of assert.equal
prog1dev Oct 15, 2018
a3289bd
test: fix uses of deprecated assert.fail with multiple args
prog1dev Oct 15, 2018
c0dad7a
doc: edit BUILDING.md
Trott Nov 8, 2018
ae2f959
test: move test-fs-watch-system-limit from sequential to pummel
mmmscott Oct 16, 2018
ee09fe3
lib: combine contructor, tag, Object into a function
Paul-Isache Nov 6, 2018
8e7f075
build,tools: update make-v8.sh for s390x
refack Oct 23, 2018
7d2bcf9
test: use NULL instead of 0 in common.h
danbev Nov 5, 2018
08c9e2b
net: simplify Socket.prototype._final
addaleax Nov 4, 2018
e9ca5bf
test: increase coverage internal readline
cyanic-webdesign Nov 6, 2018
db709c5
net: partially revert "simplify Socket.prototype._final"
addaleax Nov 10, 2018
f41eddc
stream: make `.destroy()` interact better with write queue
addaleax Nov 3, 2018
7ba4b9f
test: replacing fixture directory with temp
saurabhSiddhu Nov 4, 2018
043c70a
build: lint commit message in separate Travis job
richardlau Nov 8, 2018
c777ce7
test : compare objects not identical by reference
meelie Nov 6, 2018
07c6db9
test: fix assert.strictEqual argument order
mcqj Nov 6, 2018
3f7d7da
test: fix arguments order in assert.strictEqual()
ulisesantana Nov 6, 2018
e6ae331
doc: add oyyd to collaborators
oyyd Nov 11, 2018
808355e
test: add test for deepEqual Float32Array
yehiyam Nov 6, 2018
b23b6a4
test: add test case for completion bash flag
Nov 6, 2018
0d65b4b
doc: correct async_hooks sample outputs
Flarna Nov 2, 2018
7483c5b
test: correct order of args in assert.strictEqual()
Nov 6, 2018
a4037bc
doc: add links to Stream section
dmitigr Nov 11, 2018
d52709f
console: cover .assert with single argument
mroderick Nov 6, 2018
6805908
doc: update fs.open() changes record for optional 'flags'
rvagg Nov 8, 2018
77c2cc9
test: fix strictEqual argument order
Nov 6, 2018
13fead6
test: fix expectation in test-bootstrap-modules
ofrobots Dec 18, 2018
a5727ff
doc: sort bottom-of-file markdown links
sam-github Nov 27, 2018
57ccaf6
doc: correct async_hooks resource names
Flarna Nov 27, 2018
844bd62
deps: V8: cherry-pick 52a9e67
ofrobots Dec 14, 2018
c5140f5
http: fix regression of binary upgrade response body
mcollina Dec 14, 2018
5f649f6
test: move benchmark tests out of main test suite
Trott Nov 9, 2018
dc79fea
deps: cherry-pick http_parser_set_max_header_size
cjihrig Nov 29, 2018
82ad2c2
src: add kUInteger parsing
mcollina Dec 18, 2018
d21ff98
cli: add --max-http-header-size flag
cjihrig Dec 3, 2018
b7bb114
test: remove magic numbers in test-gc-http-client-onerror
Trott Dec 10, 2018
f30d169
doc: describe current HTTP header size limit
sam-github Nov 28, 2018
17f4208
http: add maxHeaderSize property
cjihrig Dec 6, 2018
47364b7
test: mark test-repl-envvars as flaky on AIX
MylesBorins Dec 26, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix arguments order
the actual and expected arguments in assert.strictEqual() calls are in
the wrong order. Any literal value should be the second argument while
the first argument should be the value returned by a function/be the
calculated value.

PR-URL: #24151
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
simonaco authored and codebytere committed Dec 13, 2018
commit 1d88f01be2cca783926f7b588218da843f783a1f
6 changes: 3 additions & 3 deletions test/parallel/test-fs-readfile-empty.js
Original file line number Diff line number Diff line change
@@ -35,12 +35,12 @@ fs.readFile(fn, function(err, data) {
});

fs.readFile(fn, 'utf8', function(err, data) {
assert.strictEqual('', data);
assert.strictEqual(data, '');
});

fs.readFile(fn, { encoding: 'utf8' }, function(err, data) {
assert.strictEqual('', data);
assert.strictEqual(data, '');
});

assert.ok(fs.readFileSync(fn));
assert.strictEqual('', fs.readFileSync(fn, 'utf8'));
assert.strictEqual(fs.readFileSync(fn, 'utf8'), '');